You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/02/03 07:59:01 UTC
Review Request 30550: SQOOP-1982: Integration with Sentry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP2: Integration with Sentry
Diffs
-----
core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
Diff: https://reviews.apache.org/r/30550/diff/
Testing
-------
local
Thanks,
richard zhou
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
> On Feb. 3, 2015, 8:04 a.m., shen guoquan wrote:
> > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java, line 81
> > <https://reviews.apache.org/r/30550/diff/1/?file=845222#file845222line81>
> >
> > I think the sentry integration authorizationHandler will not call the super.doInitialize in its doInitialize method. So The place of setting authenticationProvider is improper in my opinion.
Fixed with the latest patch. Thanks for your comment.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review70714
-----------------------------------------------------------
On Feb. 3, 2015, 8:18 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review70714
-----------------------------------------------------------
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java
<https://reviews.apache.org/r/30550/#comment116072>
I think the sentry integration authorizationHandler will not call the super.doInitialize in its doInitialize method. So The place of setting authenticationProvider is improper in my opinion.
- shen guoquan
On 二月 3, 2015, 7:02 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated 二月 3, 2015, 7:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71356
-----------------------------------------------------------
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java
<https://reviews.apache.org/r/30550/#comment117051>
ship it. Thanks richard
- shen guoquan
On 二月 6, 2015, 1:36 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated 二月 6, 2015, 1:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71358
-----------------------------------------------------------
Ship it!
Ship It!
- shen guoquan
On 二月 6, 2015, 1:36 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated 二月 6, 2015, 1:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 1:36 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP2: Integration with Sentry
Add a authentication provider to get do_user's name and group.
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
Diff: https://reviews.apache.org/r/30550/diff/
Testing
-------
local
Thanks,
richard zhou
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
> On Feb. 5, 2015, 12:18 a.m., Abraham Elmahrek wrote:
> > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java, line 27
> > <https://reviews.apache.org/r/30550/diff/2/?file=845234#file845234line27>
> >
> > Why not use RequestContext to pass user and group information around? A global instance seems like it would be prone to concurrency issues. Though, I think this implementation works.
> >
> > Check out RequestContext for an existing implementation. Would it not be enough?
>
> richard zhou wrote:
> We could use RequestContext, but it is not so general. You know, Sentry or other Authorization implement do not need to know the Context in Sqoop. What they need is a general Authenticator, which could get the user name and group name, and that's all. The RequestConext has a huge scope of URL request information, which should not be exposed to 3rd part code.
> It is implemented similar with Hive.
https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/security/HiveAuthenticationProvider.java
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71093
-----------------------------------------------------------
On Feb. 3, 2015, 8:18 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
> On Feb. 5, 2015, 12:18 a.m., Abraham Elmahrek wrote:
> > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java, line 27
> > <https://reviews.apache.org/r/30550/diff/2/?file=845234#file845234line27>
> >
> > Why not use RequestContext to pass user and group information around? A global instance seems like it would be prone to concurrency issues. Though, I think this implementation works.
> >
> > Check out RequestContext for an existing implementation. Would it not be enough?
We could use RequestContext, but it is not so general. You know, Sentry or other Authorization implement do not need to know the Context in Sqoop. What they need is a general Authenticator, which could get the user name and group name, and that's all. The RequestConext has a huge scope of URL request information, which should not be exposed to 3rd part code.
It is implemented similar with Hive.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71093
-----------------------------------------------------------
On Feb. 3, 2015, 8:18 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71093
-----------------------------------------------------------
Implementation seems fine, but I'm concerned about not using the RequestContext for this.
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java
<https://reviews.apache.org/r/30550/#comment116690>
Why not use RequestContext to pass user and group information around? A global instance seems like it would be prone to concurrency issues. Though, I think this implementation works.
Check out RequestContext for an existing implementation. Would it not be enough?
- Abraham Elmahrek
On Feb. 3, 2015, 8:18 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/#review71339
-----------------------------------------------------------
Ship it!
Cool
core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java
<https://reviews.apache.org/r/30550/#comment117017>
Extra ;
- Abraham Elmahrek
On Feb. 3, 2015, 8:18 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30550/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP2: Integration with Sentry
> Add a authentication provider to get do_user's name and group.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
> core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
> core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
> core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
> core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
> dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
> security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
>
> Diff: https://reviews.apache.org/r/30550/diff/
>
>
> Testing
> -------
>
> local
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 8:18 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
SQOOP2: Integration with Sentry
Add a authentication provider to get do_user's name and group.
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java 51fc2dc1349cd75cf6f16b65e882e44d516430a7
core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java cfa7a668a715bfb2212a8ddf857ff721bbd562b4
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
Diff: https://reviews.apache.org/r/30550/diff/
Testing
-------
local
Thanks,
richard zhou
Re: Review Request 30550: SQOOP-1982: Integration with Sentry
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30550/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 7:02 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description (updated)
-------
SQOOP2: Integration with Sentry
Add a authentication provider to get do_user's name and group.
Diffs
-----
core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java 6fb6d1dabcce7b81000a89cf6cadbf717fe8dd38
core/src/main/java/org/apache/sqoop/security/AuthenticationProvider.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 3db8f43e1080ba6911e66a7e9e5058331422acc0
core/src/main/java/org/apache/sqoop/security/SecurityError.java c68b666c83212d91e183d8041e694629a62b7224
core/src/main/java/org/apache/sqoop/security/SecurityFactory.java b4274108fafdcbb0ce5d73ee349211c6cfdba277
dist/src/main/server/conf/sqoop.properties fbcb1fa6bd526d87ef0c87d634dda2ea4ceac214
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthenticationProvider.java PRE-CREATION
security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java 9cd2e3385729f65aa819fa4f31a23c6958c09ac0
Diff: https://reviews.apache.org/r/30550/diff/
Testing
-------
local
Thanks,
richard zhou