You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/15 15:37:34 UTC

[GitHub] [kafka] chia7712 commented on pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

chia7712 commented on pull request #9748:
URL: https://github.com/apache/kafka/pull/9748#issuecomment-745372032


   > Can you please elaborate? I don't see the assumption you mention. The main assumption is that api keys are dense. I changed the code not to rely on the latter although it doesn't change the behavior.
   
   I assumed the order of instancing ApiKeys is strict so removing the id may makes it hard to "see" where to put the new ApiKeys in the future. However, it seems the order of instancing ApiKeys is free so the worry is invalid. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org