You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:22:52 UTC
[GitHub] [doris] XieJiann opened a new pull request, #15983: [fix](Nereids): add integer type and fix bug in nsl join
XieJiann opened a new pull request, #15983:
URL: https://github.com/apache/doris/pull/15983
# Proposed changes
1. add integer type
2. put the other conditions in NSL join to conjuncts in NSL Node
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #15983: [fix](Nereids): add integer type
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15983:
URL: https://github.com/apache/doris/pull/15983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15983: [fix](Nereids): add integer type and fix bug in nsl join
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15983:
URL: https://github.com/apache/doris/pull/15983#issuecomment-1384219580
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.72 seconds
load time: 503 seconds
storage size: 17123116761 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116153212_clickbench_pr_81326.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #15983: [fix](Nereids): add integer type and fix bug in nsl join
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #15983:
URL: https://github.com/apache/doris/pull/15983#discussion_r1071478807
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1025,7 +1025,7 @@ public PlanFragment visitPhysicalNestedLoopJoin(
leftFragment.setPlanRoot(nestedLoopJoinNode);
List<Expr> joinConjuncts = nestedLoopJoin.getOtherJoinConjuncts().stream()
.map(e -> ExpressionTranslator.translate(e, context)).collect(Collectors.toList());
- nestedLoopJoinNode.setJoinConjuncts(joinConjuncts);
+ nestedLoopJoinNode.addConjuncts(joinConjuncts);
Review Comment:
why we put join conjuncts to filter? i don't think it is right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15983: [fix](Nereids): add integer type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15983:
URL: https://github.com/apache/doris/pull/15983#issuecomment-1385018068
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on pull request #15983: [fix](Nereids): add integer type and fix bug in nsl join
Posted by GitBox <gi...@apache.org>.
XieJiann commented on PR #15983:
URL: https://github.com/apache/doris/pull/15983#issuecomment-1384753029
> maybe the right way to fix NLJ is #15979
Yeah, I will removed it
> maybe the right way to fix NLJ is #15979
Yeah, I'll remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15983: [fix](Nereids): add integer type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15983:
URL: https://github.com/apache/doris/pull/15983#issuecomment-1385018009
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #15983: [fix](Nereids): add integer type and fix bug in nsl join
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #15983:
URL: https://github.com/apache/doris/pull/15983#issuecomment-1384387071
maybe the right way to fix NLJ is #15979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org