[jira] [Commented] (PROTON-957) [proton-j] make trace logging of transfer frames more useful

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638709#comment-14638709 ] 

ASF subversion and git services commented on PROTON-957:
--------------------------------------------------------

Commit de99c06137a5f51063cce9d997424988e4fb2e29 in qpid-proton's branch refs/heads/master from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=de99c06 ]

PROTON-957: make transfer frame logging more like proton-c, report payload size rather than string length, do it regardless whether string is truncated, indicate whether string is truncated


> [proton-j] make trace logging of transfer frames more useful
> ------------------------------------------------------------
>
>                 Key: PROTON-957
>                 URL: https://issues.apache.org/jira/browse/PROTON-957
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: 0.9.1
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.10
>
>
> In proton-C, the number of payload bytes in the transfer are always reported, then a fixed maximum 1024 char string containing stringified payload is shown, and the string is appended with "...(truncated)" whenever it doesnt contain the full payload.
> In Proton-J, the entire payload is toString'ed and then a much smaller semi-fixed (its configurable via system property) maximum 80chars of stringified payload is shown, and if this is not the full string then the total number of characters in the string is displayed. This gives you no usable idea of how many bytes are in the remaining or overall payload since each byte uses 1 or 4chars to display.
> To make things more aligned and more usable, the output should be updated to be more like proton-c, logging the total payload size in the transfer first, then the stringified content which should be increased in length to match proton-c, which will make it more usable since it currently only tends to show part of the header/properties sections and gets nowhere near the actual body section bytes of the message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)