[GitHub] [geode] jchen21 commented on a change in pull request #7235: GEODE-9913: Added basicBridgePut condition to ensure VersionTag set

[GitBox <gi...@apache.org>]

jchen21 commented on a change in pull request #7235:
URL: https://github.com/apache/geode/pull/7235#discussion_r778363527



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
##########
@@ -5237,6 +5237,9 @@ public boolean basicBridgePut(Object key, Object value, byte[] deltaBytes, boole
       if (success) {
         clientEvent.setVersionTag(event.getVersionTag());
         getCachePerfStats().endPut(startPut, event.isOriginRemote());
+      } else if (clientEvent.isConcurrencyConflict() && clientEvent.isPossibleDuplicate()
+          && clientEvent.getVersionTag() == null) {
+        clientEvent.setVersionTag(event.getVersionTag());

Review comment:
       Is `stopper.checkCancelInProgress(null);` needed here as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org