You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "asha-boyapati (via GitHub)" <gi...@apache.org> on 2023/09/26 05:57:30 UTC

[GitHub] [flink] asha-boyapati opened a new pull request, #23464: Remove flakiness from tests in OperatorStateBackendTest.java

asha-boyapati opened a new pull request, #23464:
URL: https://github.com/apache/flink/pull/23464

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This PR is similar to the following PR which was accepted: https://github.com/apache/flink/pull/23298
   
   This PR makes the following tests stable:
   ```
   
   org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreSync
   org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreAsync
   ```
   
   The tests are currently flaky because the order of elements returned by iterators is non-deterministic.
   
   This PR fixes the flaky tests by making them independent of the order of elements returned by the iterators.
   
   We detected this using the NonDex tool using the following commands:
   `
   mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl flink-runtime -DnondexRuns=10 -Dtest=org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreSync`
   
   `mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl flink-runtime -DnondexRuns=10 -Dtest=org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreAsync`
   
   Please see the following Continuous Integration log that shows the flakiness:
   https://github.com/asha-boyapati/flink/actions/runs/6193757385
   
   Please see the following Continuous Integration log that shows that the flakiness is fixed by this change:
   https://github.com/asha-boyapati/flink/actions/runs/6194044449
   
   
   ## Brief change log
   
   This PR fixes the flaky tests by making them independent of the order of elements returned by the iterators.
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   This change only modifies tests slightly and does not change any underlying code.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23464: Remove flakiness from tests in OperatorStateBackendTest.java

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23464:
URL: https://github.com/apache/flink/pull/23464#issuecomment-1734885615

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c159b5a6a6689e401065026134e4b8c803dec84c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c159b5a6a6689e401065026134e4b8c803dec84c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c159b5a6a6689e401065026134e4b8c803dec84c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asha-boyapati commented on pull request #23464: [FLINK-33156][Test]Remove flakiness from tests in OperatorStateBackendTest.java

Posted by "asha-boyapati (via GitHub)" <gi...@apache.org>.
asha-boyapati commented on PR #23464:
URL: https://github.com/apache/flink/pull/23464#issuecomment-1741011694

   Thanks for your comments.  I updated the title.  I will look into your suggestion of finding and fixing similar problems together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org