You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/13 17:01:19 UTC

[GitHub] [activemq-artemis] franz1981 opened a new pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

franz1981 opened a new pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] franz1981 removed a comment on pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
franz1981 removed a comment on pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217#issuecomment-657689751


   I see that running this test (adding it to `MQTTTest`):
   
   I get on master:
   ```
   SUBSCRIBED TO  10000 in 38948 ms
   UNSUBSCRIBED TO  10000 in 8416 ms
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217#issuecomment-666894709


   I have created a rebased branch, and I'm running tests on it.
   
   if it's all good I will merge it tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] franz1981 closed pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
franz1981 closed pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217#issuecomment-657700006


   Adding this test to `MQTTTest`:
   ```java
      @Test
      public void testSendAndReceiveMQTTManyQueues() throws Exception {
         final int NUM_QUEUES = 10_000;
         final MQTTClientProvider subscriptionProvider = getMQTTClientProvider();
         initializeConnection(subscriptionProvider);
         final long start = System.currentTimeMillis();
         for (int i = 0; i < NUM_QUEUES;i++) {
            subscriptionProvider.subscribe("foo/" + i, AT_MOST_ONCE);
         }
         final long end = System.currentTimeMillis();
         long elapsed = end - start;
         System.out.println("SUBSCRIBED TO  " + NUM_QUEUES + " in " + elapsed + " ms");
         for (int i = 0; i < NUM_QUEUES;i++) {
            subscriptionProvider.unsubscribe("foo/" + i);
         }
         elapsed = System.currentTimeMillis() - end;
         System.out.println("UNSUBSCRIBED TO  " + NUM_QUEUES + " in " + elapsed + " ms");
         subscriptionProvider.disconnect();
      }
   ```
   Shows that this PR deliver a ~2X improvement over `master` on subscribe performance.
   Although not a rigorous benchmark, it already shows a tangible improvement over `master`: the real deal would be to move the MQTT logic outside the Netty loop to save it from being blocked while iterating all the bindings..
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] franz1981 commented on pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217#issuecomment-657700006


   Adding this test to `MQTTTest`:
   ```java
   @Test
      public void testSendAndReceiveMQTTManyQueues() throws Exception {
         final int NUM_QUEUES = 10_000;
         final MQTTClientProvider subscriptionProvider = getMQTTClientProvider();
         initializeConnection(subscriptionProvider);
         final long start = System.currentTimeMillis();
         for (int i = 0; i < NUM_QUEUES;i++) {
            subscriptionProvider.subscribe("foo/" + i, AT_MOST_ONCE);
         }
         final long end = System.currentTimeMillis();
         long elapsed = end - start;
         System.out.println("SUBSCRIBED TO  " + NUM_QUEUES + " in " + elapsed + " ms");
         for (int i = 0; i < NUM_QUEUES;i++) {
            subscriptionProvider.unsubscribe("foo/" + i);
         }
         elapsed = System.currentTimeMillis() - end;
         System.out.println("UNSUBSCRIBED TO  " + NUM_QUEUES + " in " + elapsed + " ms");
         subscriptionProvider.disconnect();
      }
   ```
   Deliver a ~2X improvement over `master` on subscribe performance.
   Although not a rigorous benchmark, it already shows a tangible improvement over `master`: the real deal would be to move the MQTT logic outside the Netty loop to save it from being blocked while iterating all the bindings..
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] franz1981 commented on pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217#issuecomment-657689751


   I see that running this test (adding it to `MQTTTest`):
   
   I get on master:
   ```
   SUBSCRIBED TO  10000 in 38948 ms
   UNSUBSCRIBED TO  10000 in 8416 ms
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] asfgit closed pull request #3217: ARTEMIS-2844 Improve MQTT subscribe/unsubscribe topic performance

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3217:
URL: https://github.com/apache/activemq-artemis/pull/3217


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org