You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Lars Francke <as...@lars-francke.de> on 2020/02/20 16:43:03 UTC

Review Request 72153: RANGER-2736 Enable Checkstyle rules

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72153/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2736
    https://issues.apache.org/jira/browse/RANGER-2736


Repository: ranger


Description
-------

This improves on the work done in RANGER-2725.

It enables a whole bunch of Checkstyle rules.

But it also disables that the build fails on a violation. While I'd love to have that I believe it's unrealistic for an existing codebase. We need further cleanup jiras that change the code before we can enable the rules.

 

This way people can benefit (if they set up their IDEs) from the proper warnings already.


Diffs
-----

  dev-support/checkstyle.xml 2de82b143 
  pom.xml adb8cfe29 


Diff: https://reviews.apache.org/r/72153/diff/1/


Testing
-------


Thanks,

Lars Francke