You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/07/17 20:50:15 UTC

[GitHub] beam pull request #3577: [BEAM-2626] Fix split package in SDK harness

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3577

    [BEAM-2626] Fix split package in SDK harness

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    The Java SDK harness defined classes both in its own namespace org.apache.beam.fn.harness and the org.apache.beam.runners.core namespace, resulting in a split package across multiple jars.
    
    Generally not a good practice since it breaks encapsulation and not actually useful as a hack since that method of breaking encapsulation isn't always compatible with classloader setups.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam harness-split-package

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3577
    
----
commit f1b4700f32c5ea39559145d6f5db3909439f6c80
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-07-17T20:46:46Z

    Fix split package in SDK harness
    
    The Java SDK harness defined classes both in its own namespace
    org.apache.beam.fn.harness and the org.apache.beam.runners.core namespace,
    resulting in a split package across multiple jars.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3577: [BEAM-2626] Fix split package in SDK harness

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3577


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---