[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4089: In HelixBrokerStarter, allow custom cluster change handlers

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4089: In HelixBrokerStarter, allow custom cluster change handlers
URL: https://github.com/apache/incubator-pinot/pull/4089#discussion_r273313770
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/ClusterChangeHandler.java
 ##########
 @@ -18,10 +18,16 @@
  */
 package org.apache.pinot.broker.broker.helix;
 
+import org.apache.helix.HelixConstants;
+
+
 /**
  * Handles cluster changes such as external view changes, instance config changes, live instance changes etc.
  */
 public interface ClusterChangeHandler {
 
-  void processClusterChange();
+  /**
 
 Review comment:
   please annotate this interface as an evolving application usable interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org