You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 20:31:09 UTC

[GitHub] [arrow] kou opened a new pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

kou opened a new pull request #8501:
URL: https://github.com/apache/arrow/pull/8501


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] terencehonles commented on a change in pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
terencehonles commented on a change in pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#discussion_r510670726



##########
File path: dev/archery/archery/release.py
##########
@@ -39,16 +39,19 @@ class Version(SemVer):
 
     __slots__ = SemVer.__slots__ + ('released', 'release_date')

Review comment:
       Aside: slots shouldn't need to be duplicated like this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-717671211


   @kou @kszucs any resolution on whether we want to merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-714838461


   Which approach do you like?
   Should we close this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#discussion_r514700640



##########
File path: dev/archery/archery/release.py
##########
@@ -39,16 +39,19 @@ class Version(SemVer):
 
     __slots__ = SemVer.__slots__ + ('released', 'release_date')

Review comment:
       Thanks.
   I've removed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-719125578


   @kszucs Can I merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-714542190


   I didn't see it before applied https://github.com/apache/arrow/pull/8506 which also fixes the issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-810079357


   Merging, we'll see if anyone complains :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-713864020


   https://issues.apache.org/jira/browse/ARROW-10364


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8501:
URL: https://github.com/apache/arrow/pull/8501#issuecomment-724107751


   Ping @kszucs 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #8501: ARROW-10364: [Dev][Archery] Add support for semver 2.13.0

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8501:
URL: https://github.com/apache/arrow/pull/8501


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org