[jira] [Commented] (FELIX-3590) Add system property resolution to CommandSessionImpl

["Richard S. Hall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411537#comment-13411537 ] 

Richard S. Hall commented on FELIX-3590:
----------------------------------------

It is not clear to me that this is a good idea in general. Aren't these supposed to be session properties? By definition, system properties would span sessions which means that one session could mess with another, which isn't always good when a session doesn't expect some property values to change.

For similar reasons, we avoid using system properties for framework configuration. The way we provide system properties to the framework is to have the launcher copy the system properties into the framework configuration properties (i.e., take a snapshot and give existing config properties priority over the system properties). That way different framework instances cannot interfere with each other.
                
> Add system property resolution to CommandSessionImpl
> ----------------------------------------------------
>
>                 Key: FELIX-3590
>                 URL: https://issues.apache.org/jira/browse/FELIX-3590
>             Project: Felix
>          Issue Type: Improvement
>          Components: Gogo Runtime
>    Affects Versions: gogo.runtime-0.10.0
>            Reporter: Christian Schneider
>             Fix For: gogo.runtime-0.12.0
>
>
> Currently we wrap the CommandProcessor and CommandShell in karaf to simply add the resolution of system properties.
> See org.apache.karaf.shell.console.impl.jline.Activator in the karaf console module.
> In the innermost code it is only the following we override in CommandSessionImpl.
>         public Object get(String name) {
>             Object val = super.get(name);
>             if (val == null) {
>                 val = System.getProperty(name);
>             }
>             return val;
>         }
> So I propose to add this system property resolution to gogo. This would allow us to remove all the wrapping code in karaf.
> If you are interested I can provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira