You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/07/28 05:00:51 UTC

[GitHub] [hadoop] jojochuang commented on a change in pull request #3244: HDFS-16138. BlockReportProcessingThread exit doesnt print the acutal stack

jojochuang commented on a change in pull request #3244:
URL: https://github.com/apache/hadoop/pull/3244#discussion_r677973915



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -5190,7 +5191,7 @@ public void run() {
         processQueue();
       } catch (Throwable t) {
         ExitUtil.terminate(1,
-            getName() + " encountered fatal exception: " + t);
+            getName() + " encountered fatal exception: " + ExceptionUtils.getStackTrace(t));

Review comment:
       looking at other usage in the Hadoop codebase, it seems to me a better way to print stack trace is to use the logger.
   https://github.com/apache/hadoop/blob/d0dcfc405c624f73ed1af9527bbf456a10337a6d/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceMaster.java#L353




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org