You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "badalprasadsingh (via GitHub)" <gi...@apache.org> on 2026/08/06 19:14:14 UTC
[PR] fix(table): track parents of added columns so nested moves apply [iceberg-go]
badalprasadsingh opened a new pull request, #1686:
URL: https://github.com/apache/iceberg-go/pull/1686
## Description
Fixes #1685
Record the parent id of freshly-added fields, so a nested column added and moved in the same transaction resolves to the correct parent struct instead of the table root.
## Testing
Added the regression test covering it : `TestMoveAddedNestedColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): track parents of added columns so nested moves apply [iceberg-go]
Posted by "badalprasadsingh (via GitHub)" <gi...@apache.org>.
badalprasadsingh commented on PR #1686:
URL: https://github.com/apache/iceberg-go/pull/1686#issuecomment-5208582747
While working on this fix, I ended up finding a few more bugs in `UpdateSchema`. Will raise PRs for those as well.
Looking forward to contribute more over the weekend :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): track parents of added columns so nested moves apply [iceberg-go]
Posted by "badalprasadsingh (via GitHub)" <gi...@apache.org>.
badalprasadsingh closed pull request #1686: fix(table): track parents of added columns so nested moves apply
URL: https://github.com/apache/iceberg-go/pull/1686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): track parents of added columns so nested moves apply [iceberg-go]
Posted by "badalprasadsingh (via GitHub)" <gi...@apache.org>.
badalprasadsingh commented on PR #1686:
URL: https://github.com/apache/iceberg-go/pull/1686#issuecomment-5218420850
Will merge these PR changes into #1688! As they both have a lot of common logical fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): track parents of added columns so nested moves apply [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1686:
URL: https://github.com/apache/iceberg-go/pull/1686#discussion_r3732111335
##########
table/update_schema.go:
##########
@@ -357,6 +357,10 @@ func (u *UpdateSchema) addColumn(path []string, fieldType iceberg.Type, doc stri
}
u.adds[parentID] = append(u.adds[parentID], sch.Field(0))
u.addedNameToID[fullName] = sch.Field(0).ID
Review Comment:
Only the added root's name and ID are indexed here. If `fieldType` is a struct/list/map, none of its freshly assigned descendants are entered in `addedNameToID` or `parentID`, so `findFieldForMove` cannot resolve a move within that newly added complex field. The analogous union path has the same one-level indexing. **Suggested fix:** recursively index every added descendant's full name and parent relationship, then apply moves inside the staged complex field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org