You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/04 03:51:39 UTC

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14313: compatibility with opencv4

szha commented on a change in pull request #14313: compatibility with opencv4
URL: https://github.com/apache/incubator-mxnet/pull/14313#discussion_r261916006
 
 

 ##########
 File path: Makefile
 ##########
 @@ -146,11 +146,18 @@ endif
 
 # setup opencv
 ifeq ($(USE_OPENCV), 1)
-	CFLAGS += -DMXNET_USE_OPENCV=1 $(shell pkg-config --cflags opencv)
-	LDFLAGS += $(filter-out -lopencv_ts, $(shell pkg-config --libs opencv))
+	ifeq ("$(shell pkg-config --exists opencv4; echo $$?)", "0")
 
 Review comment:
   there needs to be a way for user of make to override whatever is found by pkg-config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services