You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/20 00:26:54 UTC
[GitHub] [spark] asclepiusaka opened a new pull request #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
asclepiusaka opened a new pull request #28267:
URL: https://github.com/apache/spark/pull/28267
### What changes were proposed in this pull request?
This PR fixes a typo in deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala file.
### Why are the changes needed?
To deliver correct explanation about how the placement policy works.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
UT as specified, although shouldn't influence any functionality since it's in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961593
**[Test build #121563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616252341
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616252168
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616957488
**[Test build #121564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-617823647
Close enough - merged to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28267:
URL: https://github.com/apache/spark/pull/28267#discussion_r411873006
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
##########
@@ -40,7 +40,7 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* and cpus per task is 1, so the required container number is 15,
* and host ratio is (host1: 30, host2: 30, host3: 20, host4: 10).
*
- * 1. If requested container number (18) is more than the required container number (15):
+ * 1. If the requested container number (18) is more than the required container number (15):
Review comment:
I think we can remove this `the`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616554259
The change looks good but mind taking another look and see if there are some more typos around here? I am sure there are some more typos to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955226
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616252168
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955223
**[Test build #121563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964394
**[Test build #121564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asclepiusaka commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
asclepiusaka commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616949634
@HyukjinKwon read again and fixed several more words.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616957488
**[Test build #121564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955223
**[Test build #121563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)** for PR 28267 at commit [`94ee145`](https://github.com/apache/spark/commit/94ee145ff6f00cae23d73f15aba6419e5fd8a6b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asclepiusaka commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
asclepiusaka commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616829727
OK, will proofread again later today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28267:
URL: https://github.com/apache/spark/pull/28267#discussion_r411873134
##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
##########
@@ -63,16 +63,16 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* follow the method of 1 and 2.
*
* 4. If containers exist and some of them can match the requested localities.
- * For example if we have 1 containers on each node (host1: 1, host2: 1: host3: 1, host4: 1),
+ * For example if we have 1 container on each node (host1: 1, host2: 1: host3: 1, host4: 1),
* and the expected containers on each node would be (host1: 5, host2: 5, host3: 4, host4: 2),
* so the newly requested containers on each node would be updated to (host1: 4, host2: 4,
* host3: 3, host4: 1), 12 containers by total.
*
* 4.1 If requested container number (18) is more than newly required containers (12). Follow
- * method 1 with updated ratio 4 : 4 : 3 : 1.
+ * method 1 with an updated ratio 4 : 4 : 3 : 1.
Review comment:
I think this `an ` can be removed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616954687
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28267: [MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616252341
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org