[GitHub] spark pull request #13382: [SPARK-5581][Core] When writing sorted map output...

[ericl <gi...@git.apache.org>]

Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13382#discussion_r71262784
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala ---
    @@ -46,102 +46,145 @@ private[spark] class DiskBlockObjectWriter(
       extends OutputStream
       with Logging {
     
    +  /**
    +   * Guards against close calls, e.g. from a wrapping stream.
    +   * Call manualClose to close the stream that was extended by this trait.
    +   */
    +  private trait ManualCloseOutputStream extends OutputStream {
    +    abstract override def close(): Unit = {
    +      flush()
    +    }
    +
    +    def manualClose(): Unit = {
    +      super.close()
    +    }
    +  }
    +
       /** The file channel, used for repositioning / truncating the file. */
       private var channel: FileChannel = null
    +  private var mcs: ManualCloseOutputStream = null
       private var bs: OutputStream = null
       private var fos: FileOutputStream = null
       private var ts: TimeTrackingOutputStream = null
       private var objOut: SerializationStream = null
       private var initialized = false
    +  private var streamOpen = false
       private var hasBeenClosed = false
    -  private var commitAndCloseHasBeenCalled = false
     
       /**
        * Cursors used to represent positions in the file.
        *
    -   * xxxxxxxx|--------|---       |
    -   *         ^        ^          ^
    -   *         |        |        finalPosition
    -   *         |      reportedPosition
    -   *       initialPosition
    +   * xxxxxxxx|--------|---|
    --- End diff --
    
    Could you update the diagram? I think this is misleading since reportedPosition will always be ahead of committedPosition except during some internal processing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org