[GitHub] [cloudstack] DaanHoogland commented on pull request #4774: Added configuration and Integration test to restrict public template …

[GitBox <gi...@apache.org>]

DaanHoogland commented on pull request #4774:
URL: https://github.com/apache/cloudstack/pull/4774#issuecomment-1067668670


   > > please apply this suggestion @soreana . It reverses the cleanup from how it was created and thus prevents any blockage due to dependencies in the infra/app-scape.
   > 
   > @DaanHoogland Could you please clarify your comment. I didn't get that. Should I write it like this?
   > 
   > ```python
   >             self.update_restrict_template_configuration(self.sub_domain.id, self.sub_domain_config)
   >             self.update_restrict_template_configuration(self.domain2.id, self.domain2_config)
   >             self.update_restrict_template_configuration(self.domain1.id, self.domain1_config)
   >             cleanup_resources(self.apiclient, self.cleanup)
   > ```
   
   no @soreana , just the last line should be replaced by the one sugested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org