[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2030: add migration for directrun; update feishu model

[GitBox <gi...@apache.org>]

klesh commented on code in PR #2030:
URL: https://github.com/apache/incubator-devlake/pull/2030#discussion_r885404211


##########
plugins/helper/batch_save.go:
##########
@@ -106,47 +106,40 @@ func isPrimaryKey(f reflect.StructField) bool {
 	return strings.HasPrefix(strings.ToLower(tag), "primarykey")
 }
 
-func hasPrimaryKey(ifv reflect.Type) bool {
+func hasPrimaryKey(ifv reflect.Type, needRecursion bool) bool {

Review Comment:
   when do we need this flag? I think it should be always recursive except when `primaryKey` is found inside `gorm` tag?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org