You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/03/22 20:53:59 UTC
Review Request 66230: Added test for adding/removing framework roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added test for adding/removing framework roles.
Diffs
-----
src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d
Diff: https://reviews.apache.org/r/66230/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review201080
-----------------------------------------------------------
PASS: Mesos patch 66230 was successfully built and tested.
Reviews applied: `['66228', '66229', '66230']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
- Mesos Reviewbot Windows
On April 13, 2018, 1:38 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 1:38 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review201653
-----------------------------------------------------------
PASS: Mesos patch 66230 was successfully built and tested.
Reviews applied: `['66746', '66228', '66229', '66230']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
- Mesos Reviewbot Windows
On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202461
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66229.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66229`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
Relevant logs:
- [apply-review-66229-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/apply-review-66229-stdout.log):
```
error: patch failed: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp:684
error: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On May 4, 2018, 5:33 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for updating framework info.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202813
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66229.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66229`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
Relevant logs:
- [apply-review-66229-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/apply-review-66229-stdout.log):
```
error: patch failed: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp:684
error: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On May 9, 2018, 6:15 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated May 9, 2018, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Includes tests to validate UPDATE_FRAMEWORK call as well as specific
> tests for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for updating framework info.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202833
-----------------------------------------------------------
Bad patch!
Reviews applied: [66230, 66229, 66228, 67049, 67048, 67047, 66872]
Failed command: python support/apply-reviews.py -n -r 66229
Error:
2018-05-10 11:48:03 URL:https://reviews.apache.org/r/66229/diff/raw/ [4868/4868] -> "66229.patch" [1]
error: patch failed: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp:684
error: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22420/console
- Mesos Reviewbot
On May 9, 2018, 6:15 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated May 9, 2018, 6:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Includes tests to validate UPDATE_FRAMEWORK call as well as specific
> tests for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for updating framework info.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/
-----------------------------------------------------------
(Updated May 9, 2018, 9:15 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Summary (updated)
-----------------
Added test for updating framework info.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
Includes tests to validate UPDATE_FRAMEWORK call as well as specific
tests for adding/removing framework roles.
Diffs (updated)
-----
src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad
src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
Diff: https://reviews.apache.org/r/66230/diff/9/
Changes: https://reviews.apache.org/r/66230/diff/8-9/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202499
-----------------------------------------------------------
Bad patch!
Reviews applied: [66230, 66229, 66228, 66872]
Failed command: python support/apply-reviews.py -n -r 66229
Error:
2018-05-04 22:50:30 URL:https://reviews.apache.org/r/66229/diff/raw/ [12365/12365] -> "66229.patch" [1]
error: patch failed: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp:684
error: src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22373/console
- Mesos Reviewbot
On May 4, 2018, 5:33 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202533
-----------------------------------------------------------
Can we simplify these tests and remove the executors?
Also, over the course of reviewing this I realized that role removal should rescind offers for the removed roles and I don't think these patches address that?
src/tests/scheduler_tests.cpp
Lines 1938 (patched)
<https://reviews.apache.org/r/66230/#comment284346>
Are you setting this in order to test a non-whitelisted role? If so, maybe a short comment here?
```
// Set the whitelist in order to test a non-whitelisted role
// is considered invalid.
```
src/tests/scheduler_tests.cpp
Lines 1946-1949 (patched)
<https://reviews.apache.org/r/66230/#comment284350>
Why do you need an executor and test containerizer for this test? Can we avoid it?
src/tests/scheduler_tests.cpp
Lines 1951-1956 (patched)
<https://reviews.apache.org/r/66230/#comment284349>
Are you using this to test that the update makes its way to the allocator? Maybe a short note?
```
// We add an agent in order to test the framework update
// makes its way to the allocator.
```
src/tests/scheduler_tests.cpp
Lines 2201 (patched)
<https://reviews.apache.org/r/66230/#comment284345>
End with a period? Also, sometimes the comments quote the roles and sometimes they don't quote them (like here), can you make it consistent?
src/tests/scheduler_tests.cpp
Lines 2201-2221 (patched)
<https://reviews.apache.org/r/66230/#comment284351>
This should probably rescind offers to the removed role, can we test that? I'm guessing that's a bug in the call implementation, can you address it in a subsequent patch?
- Benjamin Mahler
On May 4, 2018, 5:33 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 5:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/
-----------------------------------------------------------
(Updated May 4, 2018, 1:33 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Changes
-------
Enhanced tests.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added test for adding/removing framework roles.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
Diff: https://reviews.apache.org/r/66230/diff/8/
Changes: https://reviews.apache.org/r/66230/diff/7-8/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review202107
-----------------------------------------------------------
PASS: Mesos patch 66230 was successfully built and tested.
Reviews applied: `['66746', '66228', '66229', '66230']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
- Mesos Reviewbot Windows
On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/
-----------------------------------------------------------
(Updated April 20, 2018, 4:19 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added test for adding/removing framework roles.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
Diff: https://reviews.apache.org/r/66230/diff/6/
Changes: https://reviews.apache.org/r/66230/diff/5-6/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/
-----------------------------------------------------------
(Updated April 12, 2018, 9:38 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Changes
-------
Addressed Till's comments.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added test for adding/removing framework roles.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
Diff: https://reviews.apache.org/r/66230/diff/5/
Changes: https://reviews.apache.org/r/66230/diff/4-5/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review199810
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66229.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66229`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
Relevant logs:
- [apply-review-66229-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/apply-review-66229-stdout.log):
```
error: patch failed: src/master/master.cpp:3421
error: src/master/master.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 22, 2018, 8:53 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 8:53 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d
>
>
> Diff: https://reviews.apache.org/r/66230/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review200923
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66228', '66229', '66230']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stdout.log):
```
[ OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0 (220 ms)
[ RUN ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[ OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 (215 ms)
[ RUN ] ContentType/SchedulerTest.ShutdownExecutor/0
[ OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (340 ms)
[ RUN ] ContentType/SchedulerTest.ShutdownExecutor/1
[ OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (369 ms)
[ RUN ] ContentType/SchedulerTest.Decline/0
[ OK ] ContentType/SchedulerTest.Decline/0 (243 ms)
[ RUN ] ContentType/SchedulerTest.Decline/1
[ OK ] ContentType/SchedulerTest.Decline/1 (265 ms)
[ RUN ] ContentType/SchedulerTest.Revive/0
[ OK ] ContentType/SchedulerTest.Revive/0 (266 ms)
[ RUN ] ContentType/SchedulerTest.Revive/1
[ OK ] ContentType/SchedulerTest.Revive/1 (267 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/0
[ OK ] ContentType/SchedulerTest.Suppress/0 (285 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/1
[ OK ] ContentType/SchedulerTest.Suppress/1 (264 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (293 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (279 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (325 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (320 ms)
[ RUN ] ContentType/SchedulerTest.AddRoles/0
d:\dcos\mesos\mesos\src\tests\scheduler_tests.cpp(2018): error: Failed to wait 15secs for offers1
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stderr.log):
```
@ 00007FF6DC5E0ED2 std::invoke<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::less<std::basic_string<char,std::char_traits<char>,
@ 00007FF6DC5F3900 lambda::internal::Partial<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::less<std::basic_string<char,std::char
@ 00007FF6DC4EE01A )<process::ProcessBase * __ptr64
@ 00007FF6DC51FCDC std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::less<std
@ 00007FF6DC5E64CC std::invoke<lambda::internal::Partial<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::less<std::basic_string<ch
@ 00007FF6DC4F5C51 )<lambda::internal::Partial<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::less<std::basic_string<char,std::ch
@ 00007FF6DC6C8036 process::ProcessBase * __ptr64)>::CallableFn<lambda::internal::Partial<<lambda_a730cf5b2ecc9b83265721115c2303d4>,mesos::internal::master::Framework * __ptr64,mesos::FrameworkInfo,std::set<std::basic_string<char,std::char_traits<char>,std::allocator<char>
@ 00007FF6DE60F65D process::ProcessBase * __ptr64)>::operator(
@ 00007FF6DE4E6BB9 process::ProcessBase::consume
@ 00007FF6DE662E2A process::DispatchEvent::consume
@ 00007FF6DA891F37 process::ProcessBase::serve
@ 00007FF6DE4F4BD0 process::ProcessManager::resume
@ 00007FF6DE5FFD11 ??
@ 00007FF6DE53CD40 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF6DE593170 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF6DE54B9EC std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF6DE64B0EA std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF6DE637B48 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF6DE61FD8D std::_Pad::_Call_func
@ 00007FFBB5B511E8 _register_onexit_function
@ 00007FFBB5B50E01 _register_onexit_function
@ 00007FFBCFD71FE4 BaseThreadInitThunk
@ 00007FFBCFEAEFC1 RtlUserThreadStart
ore steps
I0411 18:50:26.607156 12116 authenticatee.cpp:259] Received SASL authentication step
I0411 18:50:26.607156 8524 authenticator.cpp:232] Received SASL authentication step
I0411 18:50:26.607156 8524 authenticator.cpp:318] Authentication success
I0411 18:50:26.607156 22556 authenticatee.cpp:299] Authentication success
I0411 18:50:26.608153 24072 slave.cpp:1438] Successfully authenticated with master master@10.3.1.8:50432
```
- Mesos Reviewbot Windows
On March 22, 2018, 8:53 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 8:53 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 749420a23bc1a3873bd4d5aee56e78cff79bb1af
>
>
> Diff: https://reviews.apache.org/r/66230/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66230: Added test for adding/removing framework
roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review199816
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66228', '66229', '66230']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (112 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1052 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (923 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (951 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (827 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (852 ms total)
[----------] Global test environment tear-down
[==========] 947 tests from 94 test cases ran. (453723 ms total)
[ PASSED ] 946 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stderr.log):
```
I0322 22:54:34.885884 9936 executor.cpp:176] Received SUBSCRIBED event
I0322 22:54:34.889904 9936 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0322 22:54:34.889904 9936 executor.cpp:176] Received LAUNCH event
I0322 22:54:34.894891 9936 executor.cpp:648] Starting task 1af8334f-7b03-4825-b5b7-4d5d9412cadf
I0322 22:54:34.983899 9936 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0322 22:54:35.017901 9936 executor.cpp:661] Forked command at 1660
I0322 22:54:35.048874 4740 exec.cpp:445] Executor asked to shutdown
I0322 22:54:35.049862 10948 executor.cpp:176] Received SHUTDOWN event
I0322 22:54:35.049862 10948 executor.cpp:758] Shutting down
I0322 22:54:35.049862 10948 executor.cpp:868] Sending SIGTERM to process tree at pid 147f7ee77361b-0000 (default) at scheduler-375ed527-9959-4ae1-8855-e216b59fb12e@10.3.1.8:57353
I0322 22:54:35.046892 8936 hierarchical.cpp:405] Deactivated framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000
I0322 22:54:35.046892 7044 master.cpp:10380] Updating the state of task 1af8334f-7b03-4825-b5b7-4d5d9412cadf of framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0322 22:54:35.046892 7968 slave.cpp:3873] Shutting down framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000
I0322 22:54:35.046892 7968 slave.cpp:6566] Shutting down executor '1af8334f-7b03-4825-b5b7-4d5d9412cadf' of framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000 at executor(1)@10.3.1.8:57374
I0322 22:54:35.048874 11784 slave.cpp:919] Agent terminating
W0322 22:54:35.048874 11784 slave.cpp:3869] Ignoring shutdown framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000 because it is terminating
I0322 22:54:35.049862 7044 master.cpp:10479] Removing task 1af8334f-7b03-4825-b5b7-4d5d9412cadf with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000 on agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0 at slave(416)@10.3.1.8:57353 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 22:54:35.054867 9020 containerizer.cpp:2338] Destroying container 51b28e28-4367-4d18-a081-b5ddcd848489 in RUNNING state
I0322 22:54:35.054867 9020 containerizer.cpp:2952] Transitioning the state of container 51b28e28-4367-4d18-a081-b5ddcd848489 from RUNNING to DESTROYING
I0322 22:54:35.055869 7044 master.cpp:1295] Agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0 at slave(416)@10.3.1.8:57353 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0322 22:54:35.055869 7044 master.cpp:3265] Disconnecting agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0 at slave(416)@10.3.1.8:57353 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 22:54:35.055869 7044 master.cpp:3284] Deactivating agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0 at slave(416)@10.3.1.8:57353 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 22:54:35.055869 9020 launcher.cpp:156] Asked to destroy container 51b28e28-4367-4d18-a081-b5ddcd848489
I0322 22:54:35.056887 5712 hierarchical.cpp:344] Removed framework 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-0000
I0322 22:54:35.056887 5712 hierarchical.cpp:766] Agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0 deactivated
I0322 22:54:35.096860 9912 containerizer.cpp:2791] Container 51b28e28-4367-4d18-a081-b5ddcd848489 has exited
I0322 22:54:35.127905 11784 master.cpp:1137] Master terminating
I0322 22:54:35.131037 11308 hierarchical.cpp:609] Removed agent 8e78ed4c-ab68-4c23-8b91-47f7ee77361b-S0
I0322 22:54:35.504889 8152 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 22, 2018, 8:53 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66230/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 8:53 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for adding/removing framework roles.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 397a0908432ad50fa94fd939a604b096a06f8a1d
>
>
> Diff: https://reviews.apache.org/r/66230/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>