You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/06/20 21:26:43 UTC

[GitHub] brodybits opened a new pull request #160: Fix btest by using express (instead of connect, etc.)

brodybits opened a new pull request #160: Fix btest by using express (instead of connect, etc.)
URL: https://github.com/apache/cordova-js/pull/160
 
 
   THANKS for GUIDANCE:
   https://medium.freecodecamp.org/getting-off-the-ground-with-expressjs-89ada7ef4e59
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   Use `express` to fix btest
   
   THANKS for GUIDANCE: <https://medium.freecodecamp.org/getting-off-the-ground-with-expressjs-89ada7ef4e59>
   
   ### What testing has been done on this change?
   
   `grunt btest` now starts a local server; opening <http://localhost:3000> in a browser shows passing test suite
   
   This change seems to pass CI as part of WIP PR #151.
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org