You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/29 13:39:03 UTC

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3260: fix: fix migration dialog only appear after refresh

likyh commented on code in PR #3260:
URL: https://github.com/apache/incubator-devlake/pull/3260#discussion_r983556496


##########
config-ui/src/hooks/useDatabaseMigrations.jsx:
##########
@@ -36,17 +34,14 @@ function useDatabaseMigrations(Configuration = MigrationOptions) {
     const migrate = async () => {
       const m = await request.get(Configuration.apiProceedEndpoint)
       setWasMigrationSuccessful(m?.status === 200 && m?.data?.success === true)
-      setTimeout(() => {

Review Comment:
   setTimeout must write without async and await...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org