You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/14 07:14:57 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #373: feat: simplify apisix client
tokers opened a new pull request #373:
URL: https://github.com/apache/apisix-ingress-controller/pull/373
This Pull Request simplified the apisix client (`pkg/apisix`), all redundant data structures were removed and data structures in `pkg/types/apisix` are tweaked so they can be used by the apisix client seamlessly.
All change can be classified as:
* Remove `FullName` field, it's duplicated with `Name`, so just keeping `Name`.
* Remove `routeReqBody`, `routeItem`, `UpstreamReqBody`, `UpstreamItem`, just using `Route`, `Upstream` in `pkg/types/apisix`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #373: feat: simplify apisix client
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #373:
URL: https://github.com/apache/apisix-ingress-controller/pull/373#issuecomment-819593131
where to view this result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #373: feat: simplify apisix client
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #373:
URL: https://github.com/apache/apisix-ingress-controller/pull/373#issuecomment-819945217
> where to view this result?
>
> 
Weird, we really upload the codecov report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #373: feat: simplify apisix client
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #373:
URL: https://github.com/apache/apisix-ingress-controller/pull/373#issuecomment-819374209
@tokers E2E failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #373: feat: simplify apisix client
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #373:
URL: https://github.com/apache/apisix-ingress-controller/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org