You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/04/20 19:28:52 UTC
Review Request 66744: ATLAS-2590: Tag Propagation : Editing tag
attributes without specifying propagate flag value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66744/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-2590
https://issues.apache.org/jira/browse/ATLAS-2590
Repository: atlas
Description
-------
When no value is provided for propagateTag attribute:
for new classifications, propagateTag should be set to 'true'
for existing classifications, current value should not be updated
Diffs
-----
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java bf4f469f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 33b5896d
Diff: https://reviews.apache.org/r/66744/diff/1/
Testing
-------
manually tested using REST client
Thanks,
Sarath Subramanian
Re: Review Request 66744: ATLAS-2590: Tag Propagation : Editing tag
attributes without specifying propagate flag value
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66744/#review201654
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 20, 2018, 7:57 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66744/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 7:57 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2590
> https://issues.apache.org/jira/browse/ATLAS-2590
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When no value is provided for propagateTag attribute:
>
> for new classifications, propagateTag should be set to 'true'
> for existing classifications, current value should not be updated
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java bf4f469f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 33b5896d
>
>
> Diff: https://reviews.apache.org/r/66744/diff/2/
>
>
> Testing
> -------
>
> manually tested using REST client
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66744: ATLAS-2590: Tag Propagation : Editing tag
attributes without specifying propagate flag value
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66744/
-----------------------------------------------------------
(Updated April 20, 2018, 12:57 p.m.)
Review request for atlas.
Bugs: ATLAS-2590
https://issues.apache.org/jira/browse/ATLAS-2590
Repository: atlas
Description
-------
When no value is provided for propagateTag attribute:
for new classifications, propagateTag should be set to 'true'
for existing classifications, current value should not be updated
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java bf4f469f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 33b5896d
Diff: https://reviews.apache.org/r/66744/diff/2/
Changes: https://reviews.apache.org/r/66744/diff/1-2/
Testing
-------
manually tested using REST client
Thanks,
Sarath Subramanian
Re: Review Request 66744: ATLAS-2590: Tag Propagation : Editing tag
attributes without specifying propagate flag value
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66744/#review201646
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java
Line 101 (original), 101 (patched)
<https://reviews.apache.org/r/66744/#comment283142>
"boolean" ==> "Boolean"
- Madhan Neethiraj
On April 20, 2018, 7:28 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66744/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 7:28 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2590
> https://issues.apache.org/jira/browse/ATLAS-2590
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When no value is provided for propagateTag attribute:
>
> for new classifications, propagateTag should be set to 'true'
> for existing classifications, current value should not be updated
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java bf4f469f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 33b5896d
>
>
> Diff: https://reviews.apache.org/r/66744/diff/1/
>
>
> Testing
> -------
>
> manually tested using REST client
>
>
> Thanks,
>
> Sarath Subramanian
>
>