You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nifi.apache.org by bbende <gi...@git.apache.org> on 2015/12/23 16:13:05 UTC

[GitHub] nifi pull request: NIFI-1328 Explicitly setting the parameters bas...

GitHub user bbende opened a pull request:

    https://github.com/apache/nifi/pull/146

    NIFI-1328 Explicitly setting the parameters based on type in PutSQL

    NIFI-1241 was to address adding support for BOOLEAN, NUMERIC, and DECIMAL to PutSQL. In that ticket we removed the case statement where we explicitly set the parameters based on type, and instead used setObject(...).
    
    This change goes back to explicitly setting the parameters, adding those three types mentioned above, and then defaults to using setObject(...) for any types we didn't explicitly call out.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbende/nifi NIFI-1328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit 8bf78b1a52093f27fb6c30222107ec44356e15a3
Author: Bryan Bende <bb...@apache.org>
Date:   2015-12-23T15:02:21Z

    NIFI-1328 Explicitly setting the parameters based on type in PutSQL, falling back to setObject()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1328 Explicitly setting the parameters bas...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/146


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1328 Explicitly setting the parameters bas...

Posted by mattyb149 <gi...@git.apache.org>.

Github user mattyb149 commented on the pull request:

    https://github.com/apache/nifi/pull/146#issuecomment-166925957
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1328 Explicitly setting the parameters bas...

Posted by rickysaltzer <gi...@git.apache.org>.

Github user rickysaltzer commented on the pull request:

    https://github.com/apache/nifi/pull/146#issuecomment-166927662
  
    +1 LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---