You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/06/12 18:15:28 UTC

[GitHub] [arrow] icexelloss commented on a diff in pull request #35980: GH-35979: [C++] Refactor Acero scalar and hash aggregation into separate files

icexelloss commented on code in PR #35980:
URL: https://github.com/apache/arrow/pull/35980#discussion_r1227065794


##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -69,3 +69,4 @@ message SegmentedAggregateRel {
   // A list of one or more aggregate expressions along with an optional filter.
   repeated substrait.AggregateRel.Measure measures = 3;
 }
+

Review Comment:
   Nit: revert this change? (Since we don't touch this file at all probably cleaner if we don't leave a new line change)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org