You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 18:02:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #11385: Add capability of customising PyPI sources
potiuk opened a new pull request #11385:
URL: https://github.com/apache/airflow/pull/11385
This change adds capability of customising installation of PyPI
modules via custom .pypirc file. This might allow to install
dependencies from in-house, vetted registry of PyPI
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#issuecomment-706439629
[The Workflow run](https://github.com/apache/airflow/actions/runs/298365643) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#discussion_r502816373
##########
File path: docs/production-deployment.rst
##########
@@ -262,6 +262,14 @@ You can combine both - customizing & extending the image. You can build the imag
``customize`` method (either with docker command or with ``breeze`` and then you can ``extend``
the resulting image using ``FROM`` any dependencies you want.
+Customizing PYPI installation
+.............................
+
+You can customize PYPI sources used during image build by modifying .pypirc file that should be
+placed in the root of Airflow Directory. The .pypirc will never be committed to the repository
+and it will not be present in the final production image. It is added and used only in the build
Review comment:
```suggestion
and will not be present in the final production image. It is added and used only in the build
```
##########
File path: docs/production-deployment.rst
##########
@@ -262,6 +262,14 @@ You can combine both - customizing & extending the image. You can build the imag
``customize`` method (either with docker command or with ``breeze`` and then you can ``extend``
the resulting image using ``FROM`` any dependencies you want.
+Customizing PYPI installation
+.............................
+
+You can customize PYPI sources used during image build by modifying .pypirc file that should be
+placed in the root of Airflow Directory. The .pypirc will never be committed to the repository
Review comment:
```suggestion
placed in the root of Airflow Directory. This .pypirc will never be committed to the repository
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#issuecomment-706327965
[The Workflow run](https://github.com/apache/airflow/actions/runs/297983787) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#issuecomment-706524760
[The Workflow run](https://github.com/apache/airflow/actions/runs/299011701) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#issuecomment-706589227
Would love review on that one . It's rather small :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11385:
URL: https://github.com/apache/airflow/pull/11385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11385: Add capability of customising PyPI sources
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11385:
URL: https://github.com/apache/airflow/pull/11385#issuecomment-706442207
[The Workflow run](https://github.com/apache/airflow/actions/runs/298388520) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org