[incubator-ponymail] branch master updated: Bug: wordcloud.js can overwrite document ids

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ponymail.git


The following commit(s) were added to refs/heads/master by this push:
     new 0adca60  Bug: wordcloud.js can overwrite document ids
0adca60 is described below

commit 0adca60d769f9596035f1f3625f133027279b6fe
Author: Sebb <se...@apache.org>
AuthorDate: Sat Aug 24 13:13:37 2019 +0100

    Bug: wordcloud.js can overwrite document ids
    
    This fixes #507
---
 CHANGELOG.md         | 1 +
 site/js/wordcloud.js | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 28be888..110c5c8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,5 @@
 ## Changes in 0.12:
+- Bug: wordcloud.js can overwrite document ids (#507)
 - Enh: allow generator to be overridden for testing (#506)
 - Bug: generator.py does not include original medium generator (#505)
 - Enh: move generator selection to generator.py (#504)
diff --git a/site/js/wordcloud.js b/site/js/wordcloud.js
index c63dd86..e7752c5 100644
--- a/site/js/wordcloud.js
+++ b/site/js/wordcloud.js
@@ -99,7 +99,7 @@ function wordCloud(hash, width, height, debug) {
         
         
         var txt = makeWord(word, ss)
-        txt.setAttribute("id", word)
+        txt.setAttribute("id", "wordcloud_" + word)
         svg.appendChild(txt)
         if (!popped) {
             txt.setAttribute("x", 0)