You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/25 13:47:56 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #5618: arch/arm/stack: adjust SMP idle stack offset to reserve TLS space
GUIDINGLI opened a new pull request #5618:
URL: https://github.com/apache/incubator-nuttx/pull/5618
## Summary
arch/arm/stack: adjust SMP idle stack offset to reserve TLS space
## Impact
SMP
## Testing
VELA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5618: arch/arm/stack: adjust SMP idle stack offset to reserve TLS space
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5618:
URL: https://github.com/apache/incubator-nuttx/pull/5618#discussion_r814815717
##########
File path: arch/arm/src/armv7-a/arm_cpuidlestack.c
##########
@@ -121,7 +122,7 @@ int up_cpu_idlestack(int cpu, FAR struct tcb_s *tcb, size_t stack_size)
stack_alloc = (uintptr_t)g_cpu_stackalloc[cpu];
DEBUGASSERT(stack_alloc != 0 && STACK_ISALIGNED(stack_alloc));
- tcb->adj_stack_size = SMP_STACK_SIZE;
+ tcb->adj_stack_size = SMP_STACK_SIZE - sizeof(struct tls_info_s);
Review comment:
don't need, it is in the common code now:
https://github.com/apache/incubator-nuttx/blob/master/sched/init/nx_start.c#L583-L584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI closed pull request #5618: arch/arm/stack: adjust SMP idle stack offset to reserve TLS space
Posted by GitBox <gi...@apache.org>.
GUIDINGLI closed pull request #5618:
URL: https://github.com/apache/incubator-nuttx/pull/5618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org