You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/02 06:39:21 UTC
[GitHub] [pulsar] Anonymitaet opened a new pull request, #15890: [improve][doc] Highlight important tips
Anonymitaet opened a new pull request, #15890:
URL: https://github.com/apache/pulsar/pull/15890
Preview looks good
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15890: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15890:
URL: https://github.com/apache/pulsar/pull/15890#issuecomment-1144576036
@momo-jun thanks for adding the `deprecate note` to [site2/docs/develop-binary-protocol.md](https://github.com/apache/pulsar/pull/15890/files#diff-676d561a2e48838e3578efb4f9a9d5b3a49b73c20e87a4f18031eeeca2a19501).
After thinking twice, I remove it in this PR since some contributors modify the wrong file accidentally https://github.com/apache/pulsar/pull/15878#pullrequestreview-993147936
`develop-binary-protocol.md` is duplicated with `developing-binary-protocol.md`. I've checked all occurrences and ensure no versioned docs has referenced `develop-binary-protocol.md` on master. Every versioned doc has its own `develop-binary-protocol.md` or `developing-binary-protocol.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #15890: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15890:
URL: https://github.com/apache/pulsar/pull/15890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15890: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15890:
URL: https://github.com/apache/pulsar/pull/15890#issuecomment-1144528467
@momo-jun yes, thanks for reminding me, explain it in https://github.com/apache/pulsar/issues/15892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15890: [improve][doc] Highlight important tips
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15890:
URL: https://github.com/apache/pulsar/pull/15890#issuecomment-1144495488
@momo-jun review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org