You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/25 06:05:03 UTC

[GitHub] [iotdb] Beyyes commented on a diff in pull request #7712: [IOTDB-4742] [Consensus] add new api: addNewNodeToExistedGroup

Beyyes commented on code in PR #7712:
URL: https://github.com/apache/iotdb/pull/7712#discussion_r1004038554


##########
consensus/src/main/java/org/apache/iotdb/consensus/IConsensus.java:
##########
@@ -106,6 +107,17 @@ public interface IConsensus {
    */
   ConsensusGenericResponse changePeer(ConsensusGroupId groupId, List<Peer> newPeers);
 
+  /** Call this method on any member of originalGroup */
+  default ConsensusGenericResponse addNewNodeToExistedGroup(

Review Comment:
   Add more comments like `createPeer` and `addPeer`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org