You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "cucusenok (via GitHub)" <gi...@apache.org> on 2025/11/04 09:31:58 UTC
[PR] FINEREACT-2404: Improved extensibility and cleanup for 1.13.1 [fineract]
cucusenok opened a new pull request, #5141:
URL: https://github.com/apache/fineract/pull/5141
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "cucusenok (via GitHub)" <gi...@apache.org>.
cucusenok commented on PR #5141:
URL: https://github.com/apache/fineract/pull/5141#issuecomment-3484914869
> @cucusenok You should leave the version out from the commit message and PR title.
The commit message and PR title have been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup for 1.13.1 [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5141:
URL: https://github.com/apache/fineract/pull/5141#discussion_r2489516927
##########
build.gradle:
##########
@@ -698,7 +698,9 @@ configure(project.fineractJavaProjects) {
if (project.hasProperty('excludeTests')) {
filter {
- excludeTestsMatching project.property('excludeTests')
+ project.property('excludeTests').split(",").each {
+ excludeTestsMatching "*${it.trim()}*"
+ }
Review Comment:
Original matching was broken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5141:
URL: https://github.com/apache/fineract/pull/5141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5141:
URL: https://github.com/apache/fineract/pull/5141#discussion_r2489538592
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -671,7 +678,7 @@ private void validateLoanHasNoLaterChargeRefundTransactionToReverseOrCreateATran
}
}
- private void validateLoanDisbursementIsBeforeTransactionDate(final Loan loan, final LocalDate transactionDate) {
+ public void validateLoanDisbursementIsBeforeTransactionDate(final Loan loan, final LocalDate transactionDate) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -659,7 +666,7 @@ public void validateLoanGroupIsActive(final Loan loan) {
}
}
- private void validateLoanHasNoLaterChargeRefundTransactionToReverseOrCreateATransaction(Loan loan, LocalDate transactionDate,
+ public void validateLoanHasNoLaterChargeRefundTransactionToReverseOrCreateATransaction(Loan loan, LocalDate transactionDate,
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -830,7 +837,7 @@ public void validateRefund(final Loan loan, LoanTransactionType loanTransactionT
validateTransactionAmountNotExceedThresholdForMultiDisburseLoan(loan);
}
- private void validateRepaymentTypeTransactionNotBeforeAChargeRefund(final Loan loan, final LoanTransactionType loanTransactionType,
+ public void validateRepaymentTypeTransactionNotBeforeAChargeRefund(final Loan loan, final LoanTransactionType loanTransactionType,
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -245,7 +245,7 @@ public void validateDisbursement(JsonCommand command, boolean isAccountTransfer,
});
}
- private void validateDisbursementWithPostDatedChecks(final String json, final Long loanId) {
+ public void validateDisbursementWithPostDatedChecks(final String json, final Long loanId) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -680,22 +687,22 @@ private void validateLoanDisbursementIsBeforeTransactionDate(final Loan loan, fi
}
}
- private void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
+ public void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
if (DateUtils.isDateInTheFuture(transactionDate)) {
final String errorMessage = "The transaction date cannot be in the future.";
throw new InvalidLoanStateTransitionException("transaction", "cannot.be.a.future.date", errorMessage, transactionDate);
}
}
- private void validateLoanHasCurrency(final Loan loan) {
+ public void validateLoanHasCurrency(final Loan loan) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -291,7 +291,7 @@ private void validateDisbursementWithPostDatedChecks(final String json, final Lo
}
}
- private void validateDisbursementDateWithMeetingDate(final LocalDate actualDisbursementDate, final CalendarInstance calendarInstance,
+ public void validateDisbursementDateWithMeetingDate(final LocalDate actualDisbursementDate, final CalendarInstance calendarInstance,
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -680,22 +687,22 @@ private void validateLoanDisbursementIsBeforeTransactionDate(final Loan loan, fi
}
}
- private void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
+ public void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -759,7 +766,7 @@ public void validateRepaymentDateIsOnHoliday(final LocalDate repaymentDate, fina
}
}
- private void validateTransactionAmountNotExceedThresholdForMultiDisburseLoan(Loan loan) {
+ public void validateTransactionAmountNotExceedThresholdForMultiDisburseLoan(Loan loan) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanTransactionValidatorImpl.java:
##########
@@ -680,22 +687,22 @@ private void validateLoanDisbursementIsBeforeTransactionDate(final Loan loan, fi
}
}
- private void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
+ public void validateTransactionShouldNotBeInTheFuture(final LocalDate transactionDate) {
if (DateUtils.isDateInTheFuture(transactionDate)) {
final String errorMessage = "The transaction date cannot be in the future.";
throw new InvalidLoanStateTransitionException("transaction", "cannot.be.a.future.date", errorMessage, transactionDate);
}
}
- private void validateLoanHasCurrency(final Loan loan) {
+ public void validateLoanHasCurrency(final Loan loan) {
MonetaryCurrency currency = loan.getCurrency();
final ApplicationCurrency defaultApplicationCurrency = this.applicationCurrencyRepository.findOneByCode(currency.getCode());
if (defaultApplicationCurrency == null) {
throw new CurrencyNotFoundException(currency.getCode());
}
}
- private void validateClientOfficeJoiningDateIsBeforeTransactionDate(Loan loan, LocalDate transactionDate) {
+ public void validateClientOfficeJoiningDateIsBeforeTransactionDate(Loan loan, LocalDate transactionDate) {
Review Comment:
internal logic should not be exposed... it should be protected in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "cucusenok (via GitHub)" <gi...@apache.org>.
cucusenok commented on code in PR #5141:
URL: https://github.com/apache/fineract/pull/5141#discussion_r2489658901
##########
build.gradle:
##########
@@ -698,7 +698,9 @@ configure(project.fineractJavaProjects) {
if (project.hasProperty('excludeTests')) {
filter {
- excludeTestsMatching project.property('excludeTests')
+ project.property('excludeTests').split(",").each {
+ excludeTestsMatching "*${it.trim()}*"
+ }
Review Comment:
It takes time to double-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup for 1.13.1 [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5141:
URL: https://github.com/apache/fineract/pull/5141#issuecomment-3484886569
@cucusenok You should leave the version out from the commit message and PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "cucusenok (via GitHub)" <gi...@apache.org>.
cucusenok commented on PR #5141:
URL: https://github.com/apache/fineract/pull/5141#issuecomment-3484970727
@adamsaghy All mentioned access modifiers have been changed from `public` to `protected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINEREACT-2404: Improved extensibility and cleanup [fineract]
Posted by "cucusenok (via GitHub)" <gi...@apache.org>.
cucusenok commented on code in PR #5141:
URL: https://github.com/apache/fineract/pull/5141#discussion_r2489850392
##########
build.gradle:
##########
@@ -698,7 +698,9 @@ configure(project.fineractJavaProjects) {
if (project.hasProperty('excludeTests')) {
filter {
- excludeTestsMatching project.property('excludeTests')
+ project.property('excludeTests').split(",").each {
+ excludeTestsMatching "*${it.trim()}*"
+ }
Review Comment:
Deleted from this commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org