[jira] [Comment Edited] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357828#comment-15357828 ] 

Jacques Le Roux edited comment on OFBIZ-7682 at 6/30/16 8:52 PM:
-----------------------------------------------------------------

Not sure it's of much use but I'd add a checkbookNumber field. Also no need to put the *_STAMP field those are automatically generated (except if set otherwise). I'd also add the same relations EftAccount has, so with PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}
    <entity entity-name="Check"
            package-name="org.ofbiz.accounting.payment"
            title="Check Entity">
      <field name="paymentMethodId" type="id-ne"></field>
      <field name="bankName" type="name"></field>
      <field name="routingNumber" type="short-varchar"></field>
      <field name="accountType" type="short-varchar"></field>
      <field name="accountNumber" type="long-varchar"></field>
      <field name="checkbookNumber" type="long-varchar"></field>
      <field name="nameOnAccount" type="name"></field>
      <field name="companyNameOnAccount" type="name"></field>
      <field name="contactMechId" type="id-ne"></field>
      <field name="yearsAtBank" type="numeric"></field>
      <prim-key field="paymentMethodId"/>
      <relation type="one" fk-name="CHECK_PMETH" rel-entity-name="PaymentMethod">
        <key-map field-name="paymentMethodId"/>
      </relation>
      <relation type="one" fk-name="CHECK_CMECH" rel-entity-name="ContactMech">
        <key-map field-name="contactMechId"/>
      </relation>
      <relation type="one" fk-name="CHECK_PADDR" rel-entity-name="PostalAddress">
        <key-map field-name="contactMechId"/>
      </relation>
    </entity>
{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even in the EftAccount, it's never used OOTB. And this characteristic is more a relation between 2 parties. So I don't see the need to have it there. It should be modeled otherwise.



was (Author: jacques.le.roux):
Not sure it's of much use but I'd add a checkbookNumber field. Also no need to put the *_STAMP field those are automatically generated (except if set otherwise). I'd also add the same relations EftAccount has, so with PaymentMethod, ContactMech and PostalAddress. It would then be:
{code}
    <entity entity-name="Check"
            package-name="org.ofbiz.accounting.payment"
            title="EFT Account Information Entity">
      <field name="paymentMethodId" type="id-ne"></field>
      <field name="bankName" type="name"></field>
      <field name="routingNumber" type="short-varchar"></field>
      <field name="accountType" type="short-varchar"></field>
      <field name="accountNumber" type="long-varchar"></field>
      <field name="checkbookNumber" type="long-varchar"></field>
      <field name="nameOnAccount" type="name"></field>
      <field name="companyNameOnAccount" type="name"></field>
      <field name="contactMechId" type="id-ne"></field>
      <field name="yearsAtBank" type="numeric"></field>
      <prim-key field="paymentMethodId"/>
      <relation type="one" fk-name="CHECK_PMETH" rel-entity-name="PaymentMethod">
        <key-map field-name="paymentMethodId"/>
      </relation>
      <relation type="one" fk-name="CHECK_CMECH" rel-entity-name="ContactMech">
        <key-map field-name="contactMechId"/>
      </relation>
      <relation type="one" fk-name="CHECK_PADDR" rel-entity-name="PostalAddress">
        <key-map field-name="contactMechId"/>
      </relation>
    </entity>
{code}

BTW, for the sake of the analysis, I'm not sure the yearsAtBank is useful. Even in the EftAccount, it's never used OOTB. And this characteristic is more a relation between 2 parties. So I don't see the need to have it there. It should be modeled otherwise.


> Define and add new entity for 'Check' as Payment Method
> -------------------------------------------------------
>
>                 Key: OFBIZ-7682
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7682
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting
>    Affects Versions: 14.12.01, 15.12.01
>            Reporter: Swapnil Shah
>            Assignee: Swapnil Shah
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)