You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/21 15:19:08 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2161:
hw/mcu/dialog: Apply trim and preferred values
apache-mynewt-bot removed a comment on issue #2161: hw/mcu/dialog: Apply trim and preferred values
URL: https://github.com/apache/mynewt-core/pull/2161#issuecomment-576725550
<!-- style-bot -->
## Style check summary
#### hw/mcu/dialog/da1469x/src/da1469x_pd.c
<details>
```diff
@@ -31,7 +31,7 @@
};
struct da1469x_pd_trimv {
- uint8_t count;
+ uint8_t count;
uint32_t *words;
};
@@ -152,12 +152,12 @@
static void
apply_preferred_pd_aon(void)
{
- if (get_reg32(0x500000f8) == 0x00008800) {
- set_reg32(0x500000f8, 0x00007700);
- }
- set_reg32_mask(0x50000050, 0x00001000, 0x00001020);
- set_reg32(0x500000a4, 0x000000ca);
- set_reg32_mask(0x50000064, 0x0003ffff, 0x041e6ef4);
+ if (get_reg32(0x500000f8) == 0x00008800) {
+ set_reg32(0x500000f8, 0x00007700);
+ }
+ set_reg32_mask(0x50000050, 0x00001000, 0x00001020);
+ set_reg32(0x500000a4, 0x000000ca);
+ set_reg32_mask(0x50000064, 0x0003ffff, 0x041e6ef4);
}
int
@@ -196,7 +196,9 @@
CRG_TOP->PMU_CTRL_REG &= ~bitmask;
bitmask = 1 << (g_da1469x_pd_desc[pd].stat_down_bit + 1);
- while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+ while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+ ;
+ }
if (load) {
da1469x_pd_apply_trimv(pd);
@@ -242,7 +244,9 @@
CRG_TOP->PMU_CTRL_REG |= bitmask;
bitmask = 1 << g_da1469x_pd_desc[pd].stat_down_bit;
- while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0);
+ while ((CRG_TOP->SYS_STAT_REG & bitmask) == 0) {
+ ;
+ }
ret = 1;
}
```
</details>
#### hw/mcu/dialog/da1469x/src/system_da1469x.c
<details>
```diff
@@ -50,15 +50,15 @@
:
: [msplim] "r" (&__StackLimit)
:
- );
+ );
/* TODO: Check chip version.
- assert(CHIP_VERSION->CHIP_ID1_REG == '2');
- assert(CHIP_VERSION->CHIP_ID2_REG == '5');
- assert(CHIP_VERSION->CHIP_ID3_REG == '2');
- assert(CHIP_VERSION->CHIP_ID4_REG == '2');
- assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
- assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
+ assert(CHIP_VERSION->CHIP_ID1_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID2_REG == '5');
+ assert(CHIP_VERSION->CHIP_ID3_REG == '2');
+ assert(CHIP_VERSION->CHIP_ID4_REG == '2');
+ assert(CHIP_VERSION->CHIP_REVISION_REG == 'A');
+ assert(CHIP_VERSION->CHIP_TEST1_REG == 'B');
*/
/* Enable FPU when using hard-float */
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services