You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/07 11:27:11 UTC

[GitHub] maskit commented on issue #1063: ENH: Add code formatter for Java

maskit commented on issue #1063: ENH: Add code formatter for Java
URL: https://github.com/apache/incubator-pulsar/pull/1063#issuecomment-363740425
 
 
   I'm basically +1 on this, but I'm not sure `clean` is an appropriate phase. People might be confused if code was modified when they run `mvn clean`. Also, if we are going to check code format on CI, we shouldn't format code during the build. Otherwise the check wouldn't work. Maybe we should use git hook (pre-commit) instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services