You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/08/16 08:33:14 UTC

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #341: increase configuration parameters of cache

qiaojialin commented on a change in pull request #341: increase configuration parameters of cache
URL: https://github.com/apache/incubator-iotdb/pull/341#discussion_r314626259
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
 ##########
 @@ -263,6 +267,26 @@ private void initMemoryAllocate(Properties properties) {
       conf.setAllocateMemoryForRead(
           maxMemoryAvailable * Integer.parseInt(proportions[1].trim()) / proportionSum);
     }
+
+    if (!conf.isMetaDataCacheEnable()) {
+      return;
+    }
+
+    String queryMemoryAllocateProportion = properties
+        .getProperty("filemeta_chunkmeta_free_memory_proportion");
+    if (queryMemoryAllocateProportion != null) {
+      String[] proportions = queryMemoryAllocateProportion.split(":");
+      int proportionSum = 0;
+      for (String proportion : proportions) {
+        proportionSum += Integer.parseInt(proportion.trim());
 
 Review comment:
   How about checking minus numbers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services