You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "Gerrit-K (via GitHub)" <gi...@apache.org> on 2025/01/02 13:55:44 UTC

[PR] Helm: use `tpl` to render the persistence secret [polaris]

Gerrit-K opened a new pull request, #603:
URL: https://github.com/apache/polaris/pull/603

   When using helm charts, it is recommended to use release-specific names in resources, e.g. via `{{ .Release.Name }}-` prefix. If the persistence config secret is created along this release, it would be beneficial to allow using the templated name, e.g.
   ```yaml
   persistenceConfigSecret: {{ .Release.Name }}-persistence-config
   ```
   instead of having to hardcode it like
   ```yaml
   persistenceConfigSecret: myrelease-persistence-config
   ```
   
   This MR simply uses the `tpl` directive to evaluate any template expressions in the value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Helm: use `tpl` to render the persistence secret [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #603:
URL: https://github.com/apache/polaris/pull/603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Helm: use `tpl` to render the persistence secret [polaris]

Posted by "Gerrit-K (via GitHub)" <gi...@apache.org>.
Gerrit-K commented on PR #603:
URL: https://github.com/apache/polaris/pull/603#issuecomment-2567919081

   > Looks good to me. Please update the helm test cases to reflect this.
   
   Thanks, good point! Added a test case for both, the deployment and the job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Helm: use `tpl` to render the persistence secret [polaris]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #603:
URL: https://github.com/apache/polaris/pull/603#issuecomment-2567888380

   Looks good to me. Please update the helm test cases to reflect this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org