You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/01/21 08:02:12 UTC

[GitHub] [incubator-inlong] baomingyu opened a new pull request #2262: [INLONG-2218][DataProxy] Inlong-DataProxy support authentication access TDMQ

baomingyu opened a new pull request #2262:
URL: https://github.com/apache/incubator-inlong/pull/2262


    Inlong-DataProxy support authentication access TDMQ
   
   Fixes #2218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #2262: [INLONG-2218][DataProxy] Inlong-DataProxy support authentication access Pulsar

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2262:
URL: https://github.com/apache/incubator-inlong/pull/2262


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2262: [INLONG-2218][DataProxy] Inlong-DataProxy support authentication access Pulsar

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2262:
URL: https://github.com/apache/incubator-inlong/pull/2262#discussion_r789437794



##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsar/PulsarClientService.java
##########
@@ -228,10 +237,14 @@ private void createConnection(CreatePulsarClientCallBack callBack) throws FlumeE
     }
 
     private PulsarClient initPulsarClient(String pulsarUrl) throws Exception {
-        return PulsarClient.builder()
-                .serviceUrl(pulsarUrl)
-                .connectionTimeout(clientTimeout, TimeUnit.SECONDS)
-                .build();
+        ClientBuilder builder = PulsarClient.builder();
+        if (PULSAR_DEFAULT_AUTH_TYPE.equals(authType) && StringUtils.isNotEmpty(token)) {
+            builder.authentication(AuthenticationFactory.token(token));
+        }
+        builder.serviceUrl(pulsarUrl)
+                .connectionTimeout(clientTimeout, TimeUnit.SECONDS);
+        return builder.build();
+

Review comment:
       remove empty line

##########
File path: inlong-dataproxy/conf/flume-mulit-pulsar-udp-example.conf
##########
@@ -79,6 +79,9 @@ agent1.channels.ch-msg6.fsyncInterval = 10
 agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
 agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.dataproxy.sink.PulsarSink
 agent1.sinks.pulsar-sink-msg1.pulsar_server_url_list = pulsar://127.0.0.1:6650
+#Optional pulsar auth type and token config
+#agent1.sinks.pulsar-sink-msg1.pulsar_auth_type = token
+#agent1.sinks.pulsar-sink-msg1.pulsar_token = XXXXXXXXXX

Review comment:
       change the default value for the token，`xxxxx` is not useful.

##########
File path: inlong-dataproxy/conf/flume-mulit-pulsar-udp-example.conf
##########
@@ -103,6 +109,9 @@ agent1.sinks.pulsar-sink-msg2.disk-io-rate-per-sec=20000000
 agent1.sinks.pulsar-sink-msg5.channel = ch-msg5
 agent1.sinks.pulsar-sink-msg5.type = org.apache.inlong.dataproxy.sink.PulsarSink
 agent1.sinks.pulsar-sink-msg5.pulsar_server_url_list = pulsar://127.0.0.1:6650
+#Optional pulsar auth type and token config
+#agent1.sinks.pulsar-sink-msg5.pulsar_auth_type = token
+#agent1.sinks.pulsar-sink-msg5.pulsar_token = XXXXXXXXXX

Review comment:
       ditto

##########
File path: inlong-dataproxy/conf/flume-mulit-pulsar-udp-example.conf
##########
@@ -91,6 +94,9 @@ agent1.sinks.pulsar-sink-msg1.disk-io-rate-per-sec=20000000
 agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
 agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.dataproxy.sink.PulsarSink
 agent1.sinks.pulsar-sink-msg2.pulsar_server_url_list = pulsar://127.0.0.1:6650
+#Optional pulsar auth type and token config
+#agent1.sinks.pulsar-sink-msg2.pulsar_auth_type = token
+#agent1.sinks.pulsar-sink-msg2.pulsar_token = XXXXXXXXXX

Review comment:
       ditto

##########
File path: inlong-dataproxy/conf/flume-mulit-pulsar-udp-example.conf
##########
@@ -91,6 +94,9 @@ agent1.sinks.pulsar-sink-msg1.disk-io-rate-per-sec=20000000
 agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
 agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.dataproxy.sink.PulsarSink
 agent1.sinks.pulsar-sink-msg2.pulsar_server_url_list = pulsar://127.0.0.1:6650
+#Optional pulsar auth type and token config
+#agent1.sinks.pulsar-sink-msg2.pulsar_auth_type = token

Review comment:
       add a space after `#`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] baomingyu commented on a change in pull request #2262: [INLONG-2218][DataProxy] Inlong-DataProxy support authentication access Pulsar

Posted by GitBox <gi...@apache.org>.
baomingyu commented on a change in pull request #2262:
URL: https://github.com/apache/incubator-inlong/pull/2262#discussion_r790097352



##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsar/PulsarClientService.java
##########
@@ -228,10 +237,14 @@ private void createConnection(CreatePulsarClientCallBack callBack) throws FlumeE
     }
 
     private PulsarClient initPulsarClient(String pulsarUrl) throws Exception {
-        return PulsarClient.builder()
-                .serviceUrl(pulsarUrl)
-                .connectionTimeout(clientTimeout, TimeUnit.SECONDS)
-                .build();
+        ClientBuilder builder = PulsarClient.builder();
+        if (PULSAR_DEFAULT_AUTH_TYPE.equals(authType) && StringUtils.isNotEmpty(token)) {
+            builder.authentication(AuthenticationFactory.token(token));
+        }
+        builder.serviceUrl(pulsarUrl)
+                .connectionTimeout(clientTimeout, TimeUnit.SECONDS);
+        return builder.build();
+

Review comment:
       done
   

##########
File path: inlong-dataproxy/conf/flume-mulit-pulsar-udp-example.conf
##########
@@ -91,6 +94,9 @@ agent1.sinks.pulsar-sink-msg1.disk-io-rate-per-sec=20000000
 agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
 agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.dataproxy.sink.PulsarSink
 agent1.sinks.pulsar-sink-msg2.pulsar_server_url_list = pulsar://127.0.0.1:6650
+#Optional pulsar auth type and token config
+#agent1.sinks.pulsar-sink-msg2.pulsar_auth_type = token
+#agent1.sinks.pulsar-sink-msg2.pulsar_token = XXXXXXXXXX

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2262: [INLONG-2218][DataProxy] Inlong-DataProxy support authentication access Pulsar

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2262:
URL: https://github.com/apache/incubator-inlong/pull/2262#issuecomment-1019034549


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2262](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2817d8) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/9301823501c3baff7eaa884f3a96ca586ec40919?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9301823) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2262/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2262      +/-   ##
   ============================================
   - Coverage     12.54%   12.54%   -0.01%     
   + Complexity     1219     1217       -2     
   ============================================
     Files           420      420              
     Lines         36208    36208              
     Branches       5674     5674              
   ============================================
   - Hits           4543     4541       -2     
     Misses        30859    30859              
   - Partials        806      808       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/2262/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.79%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9301823...c2817d8](https://codecov.io/gh/apache/incubator-inlong/pull/2262?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org