[GitHub] [superset] ktmud edited a comment on pull request #19421: perf: migrate new dataset models with INSERT FROM

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #19421:
URL: https://github.com/apache/superset/pull/19421#issuecomment-1086218951


   @eschutho I propose to change current migration to no-op and move my updated code to a new migration. 
   
   See an earlier message I sent in Slack:
   
   ---
   
   Hi, I noticed we are making more adjustments to SIP-68 models and have prepared a [couple](https://github.com/apache/superset/pull/19425) of [more](https://github.com/apache/superset/pull/19487) db migrations. I’m wondering whether we should bundle all these migrations (including the first one that’s already merged) into one new migration and change the original migration to no-op.
   
   **Pros:**
   
   - Reduced total migration time: bundle everything should be faster than running them separately
   - We get a chance to fix a couple of more errors such as [using MediumText for MySQL](https://github.com/apache/superset/pull/19421#discussion_r839942807) and [incorrect additive_metric_types matching](https://github.com/apache/superset/pull/19421#discussion_r839903477)
   - We get a chance to copy over other missing data such as [changed on and last updated](https://github.com/apache/superset/pull/19421#discussion_r840089807)
   - We can re-ID the copied entities to follow the original ones, making it easier to spot-check potential data inconsistency bugs down the road
   - Everyone’s db is in a clean and consistent state
   
   **Cons:**
   - Those who already ran the migration and bore the slowness may have to experience it again
   
   Happy to incorporate [#19487](https://github.com/apache/superset/pull/19487/) and [#19425](https://github.com/apache/superset/pull/19425) to [my PR](https://github.com/apache/superset/pull/19421) if they are still needed. (edited)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org