[GitHub] [pinot] somandal commented on a diff in pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

["somandal (via GitHub)" <gi...@apache.org>]

somandal commented on code in PR #10845:
URL: https://github.com/apache/pinot/pull/10845#discussion_r1230366679


##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintStrategyTable.java:
##########
@@ -29,6 +29,9 @@
 public class PinotHintStrategyTable {
   public static final String INTERNAL_AGG_INTERMEDIATE_STAGE = "aggIntermediateStage";
   public static final String INTERNAL_AGG_FINAL_STAGE = "aggFinalStage";
+  // Hint to denote that aggregation is to be run as a single stage rather than split into an intermediate and a final
+  // stage
+  public static final String INTERNAL_IS_SINGLE_STAGE_AGG = "isSingleStageAgg";

Review Comment:
   @walterddr this will make more sense once you look at this PR: https://github.com/apache/pinot/pull/10846
   We cannot leverage the final stage hint because we need to differentiate between the intermediate stage actually running in the v1 engine as a leaf stage vs. intermediate stage running in the v2 engine after performing operations such as JOIN (agg on top of join vs. agg in leaf)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org