[GitHub] [hudi] suryaprasanna commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable

["suryaprasanna (via GitHub)" <gi...@apache.org>]

suryaprasanna commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1207466099


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -170,6 +170,12 @@ public class HoodieStorageConfig extends HoodieConfig {
       .withDocumentation("Expected additional compression as records move from log files to parquet. Used for merge_on_read "
           + "table to send inserts into log files & control the size of compacted parquet file.");
 
+  public static final ConfigProperty<String> HOODIE_AVRO_WRITE_SUPPORT_CLASS = ConfigProperty
+      .key("hoodie.avro.write.support.class")
+      .defaultValue("org.apache.hudi.avro.HoodieAvroWriteSupport")

Review Comment:
   Yes, added markAdvanced to the config.



##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroWriteSupport.java:
##########
@@ -35,17 +36,19 @@
 /**
  * Wrap AvroWriterSupport for plugging in the bloom filter.
  */
-public class HoodieAvroWriteSupport extends AvroWriteSupport {
+public class HoodieAvroWriteSupport<T> extends AvroWriteSupport<T> {

Review Comment:
   I think, if users are over-ridding write() method from the AvroWriteSupport class, they require the generics to be passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org