You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/28 22:38:07 UTC
[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
AndrewZhaoLuo opened a new pull request #8363:
URL: https://github.com/apache/tvm/pull/8363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870106414
Does it work if we use Target.export for serialization? This method converts a Target to a JSON-like dict and should preserve all the information.
Equality check is another big issue. I discussed with @comaniac a while ago, but haven’t got a conclusion yet when should two targets are considered “equal”: If one target has -libs=cudnn and the other doesn’t, are they equal to each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870093432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-871606570
The main lesson here is if we use python we must use multiprocessing to get parallelism. If we use multiprocessing we have to assume sometimes we cannot use a direct `fork()` to get a subprocess.
There might be other bugs as if do not have a direct `fork()` arguments to the children process need to be serialized and reserialized. This has two implications:
- Pointer equality assumptions are broken -- even if two objects shared a pointer to a resource before they might not after serialization and reserialization. This one is annoying.
- Things passed to subprocesses must be pickleable which they might not be. The solution is to make things pickleable like I did here by removing the anonymous function closure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870093432
Still a draft, there still is a problem with `src/target/target.cc` construction.
```
Target::Target(Target target, Target host) {
ObjectPtr<TargetNode> n = make_object<TargetNode>(*target.get());
CHECK(!n->host.defined() || n->host.same_as(host))
<< "ValueError: Adding a host to a target whose host field has been defined target: "
<< n->host << " host: " << host << " ptr target: " << n.get()
<< " ptr host: " << make_object<TargetNode>(*host.get()).get();
;
// add target host into host field
n->host = std::move(host);
data_ = std::move(n);
}
```
Check failed
Spawn breaks pointer equality which was the assumption. We now need a deep equality thing for "tvm::Target" I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8363:
URL: https://github.com/apache/tvm/pull/8363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-871606570
The main lesson here is if we use python we must use multiprocessing to get parallelism. If we use multiprocessing we have to assume sometimes we cannot use a direct `fork()` to get a subprocess.
There might be other bugs as if do not have a direct `fork()` as arguments to the children process need to be serialized and reserialized. This has two implications:
- Pointer equality assumptions are broken -- even if two objects shared a pointer to a resource before they might not after serialization and reserialization. This one is annoying.
- Things passed to subprocesses must be pickleable which they might not be. The solution is to make things pickleable like I did here by removing the anonymous function closure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870093432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870942079
I chatted offline with @zxybazh about this and he says the check is not needed.
Furthermore, the entire target system is going to revamped relatively soon.
Therefore I have elected to just remove the check making this PR hopefully less controversial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-871606570
The main lesson here is if we use python we must use multiprocessing to get parallelism. If we use multiprocessing we have to assume sometimes we cannot use a direct `fork()` to get a subprocess.
There might be other bugs as if do not have a direct `fork()` as arguments to the children process need to be serialized and reserialized. This has two implications:
- Pointer equality assumptions are broken -- even if two objects shared a pointer to a resource before they might not after serialization and reserialization. This one is annoying.
- Things passed to subprocesses must be pickleable which they might not be. The solution is to make things pickleable like I did here by removing the anonymous function closure.
This also has implications for Windows which does not use the fork() - exec() model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870093432
Still a draft, there still is a problem with `src/target/target.cc` construction.
Spawn breaks pointer equality which was the assumption. We now need a deep equality thing for "tvm::Target" I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870128615
Hmm, I'll be honest, I don't quite understand the target/host part of tvm very well. I was hoping you could give context on this since you were the last person on git to touch the line. Specifically the proper usage of the commented out check.
This method appears in a lot of places https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L171. And the problematic line specifically is this one: https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L200
Before it worked since a majority of tested systems used `fork()` as the method for multiprocessing. macOS and windows by default use a different process which is causing this error. If I had to guess why this is the case, it is because macOS and windows serialize and deserialize arguments to a process which breaks the pointer equality assumption in the 2 arg constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870916059
Ok folks ready for review. This works with llvm and metal on m1 mac with "spawn" multiprocessing enabled. I also added a test to make sure other multiprocessing tests work.
The key assumption is when invoking the `Target::Target(Target target, Target host)` constructor it's ok if `target->host` and `host` refer to the same underlying target. This appears to be the intention with the line `n->host.same_as(host)`.
However `spawn()` breaks any pointer equality so we need to have some sort of deep equals. This does not exist so for now I'm just comparing the human readable strings instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870128615
Hmm, I'll be honest, I don't quite understand the target/host part of tvm very well. I was hoping you could give context on this since you were the last person on git to touch the line. Specifically the proper usage of the commented out check.
This method appears in a lot of places https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L200. And the problematic line specifically is this one: `https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L200`
Before it worked since a majority of tested systems used `fork()` as the method for multiprocessing. macOS and windows by default use a different process which is causing this error. If I had to guess why this is the case, it is because macOS and windows serialize and deserialize arguments to a process which breaks the pointer equality assumption in the 2 arg constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870112769
> Equality check is another big issue. I discussed with @comaniac a while ago, but haven’t got a conclusion yet when should two targets are considered “equal”: If one target has -libs=cudnn and the other doesn’t, are they equal to each other?
Exactly. It seems to me that we ultimately need two APIs for target: one (i.e., `==`) checks if two targets are exactly the same, and the other (`.compatible(self, other)`) checks if target A is compatible to target B. The problem is the definition of "compatible" targets. In my own experience, `compatible` is much more useful than `==`, as in many cases, people care more about whether a model/schedule built with target A can be used in target B. Meanwhile, we can still have the equality check first for internal use cases like this one I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870130246
@zxybazh The target host and the new host are functionally the same, but not the same object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870128615
Hmm, I'll be honest, I don't quite understand the target/host part of tvm very well. I was hoping you could give context on this since you were the last person on git to touch the line. Specifically the proper usage of the commented out check.
This method appears in a lot of places https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L200. And the problematic line specifically is this one: https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L200
Before it worked since a majority of tested systems used `fork()` as the method for multiprocessing. macOS and windows by default use a different process which is causing this error. If I had to guess why this is the case, it is because macOS and windows serialize and deserialize arguments to a process which breaks the pointer equality assumption in the 2 arg constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870904931
> > OK, in that case, is it possible that you explicitly clear the host field of the given target object and then construct it this way? Because `fork` seem to be a special case, and generally the host should always be consistent.
>
> Not from the python end it looks like.
Would `target.host = None` work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870112870
Hmm I don't understand a lot of the host target stuff. In this case I believe we need equality to be exact equality.
The problem you are describing could be another form of equality?
In any case me and @tkonolige might just turn off the check for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870125243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870106414
Does it work if we use Target.export for serialization? This method converts a Target to a JSON-like dict and should preserve all the information.
Equality check is another big issue. I discussed with @comaniac a while ago, but haven’t got a conclusion yet when should two targets are considered “equal”: If one target has -libs=cudnn and the other doesn’t, are they equal to each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870125243
Hi Andrew, just curious about the context, why in this case would we add a target host to a target object that already has a different host?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870793648
> OK, in that case, is it possible that you explicitly clear the host field of the given target object and then construct it this way? Because `fork` seem to be a special case, and generally the host should always be consistent.
Not from the python end it looks like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870122577
@zxybazh thoughts with turning off this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870130246
@zxybazh The target host and the new host are functionally the same, but not the same object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-871601714
Hey @AndrewZhaoLuo, would you like to briefly summarize the lessons here on properly supporting macOS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-871989194
Thank you @AndrewZhaoLuo for the awesome work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870917419
> > > OK, in that case, is it possible that you explicitly clear the host field of the given target object and then construct it this way? Because `fork` seem to be a special case, and generally the host should always be consistent.
> >
> >
> > Not from the python end it looks like.
>
> Would `target.host = None` work?
It does not actually modify the underlying object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870112769
> Equality check is another big issue. I discussed with @comaniac a while ago, but haven’t got a conclusion yet when should two targets are considered “equal”: If one target has -libs=cudnn and the other doesn’t, are they equal to each other?
Exactly. It seems to me that we ultimately need two APIs for target: one (i.e., `==`) checks if two targets are exactly the same, and the other (`.compatible(self, other)`) checks if target A is compatible to target B. The problem is the definition of "compatible" targets. In my own experience, `compatible` is much more useful than `==`, as in many cases, people care more about whether a model/schedule built with target A can be used in target B. Meanwhile, we can still have the equality check first for internal use cases like this one I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870238391
OK, in that case, is it possible that you explicitly clear the host field of the given target object and then construct it this way? Because `fork` seem to be a special case, and generally the host should always be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org