You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/10 13:57:12 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #866: Added
Mustache extension #803
aldettinger opened a new pull request #866: Added Mustache extension #803
URL: https://github.com/apache/camel-quarkus/pull/866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] aldettinger closed pull request #866: Added
Mustache extension #803
Posted by GitBox <gi...@apache.org>.
aldettinger closed pull request #866: Added Mustache extension #803
URL: https://github.com/apache/camel-quarkus/pull/866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on a change in pull request #866:
Added Mustache extension #803
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #866: Added Mustache extension #803
URL: https://github.com/apache/camel-quarkus/pull/866#discussion_r390338107
##########
File path: integration-tests/mustache/src/main/java/org/apache/camel/quarkus/component/mustache/it/MustacheRoute.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.mustache.it;
+
+import io.quarkus.runtime.annotations.RegisterForReflection;
+import org.apache.camel.BindToRegistry;
+import org.apache.camel.builder.RouteBuilder;
+
+@RegisterForReflection(fields = true, methods = false)
+public class MustacheRoute extends RouteBuilder {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request
#866: Added Mustache extension #803
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #866: Added Mustache extension #803
URL: https://github.com/apache/camel-quarkus/pull/866#discussion_r390334637
##########
File path: integration-tests/mustache/src/main/java/org/apache/camel/quarkus/component/mustache/it/MustacheRoute.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.mustache.it;
+
+import io.quarkus.runtime.annotations.RegisterForReflection;
+import org.apache.camel.BindToRegistry;
+import org.apache.camel.builder.RouteBuilder;
+
+@RegisterForReflection(fields = true, methods = false)
+public class MustacheRoute extends RouteBuilder {
Review comment:
As I get it, all route classes containing `@BindToRegistry` would need to register fields for reflection in order to work in native mode. This behavior is linked to [this code](https://github.com/apache/camel/blob/master/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java#L212..L217). Would it make sense to open a ticket to improve this ? like finding a way to make @BindToRegistry registering classes for reflection or customizing bean post processing for camel-quarkus ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] aldettinger commented on issue #866: Added Mustache
extension #803
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #866: Added Mustache extension #803
URL: https://github.com/apache/camel-quarkus/pull/866#issuecomment-597132984
Ok, thanks. Build issue seems unrelated so I'm gonna rebase and push.
RegisterForReflection follow up issue #867 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services