You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/19 03:56:02 UTC
[GitHub] [incubator-doris] pengxiangyu opened a new pull request, #9678: add tablet erros when close_wait return error
pengxiangyu opened a new pull request, #9678:
URL: https://github.com/apache/incubator-doris/pull/9678
# Proposed changes
Issue Number: close #9418
## Problem Summary:
add tablet erros when close_wait return error
## Checklist(Required)
1. Does it affect the original behavior: (No/
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] pengxiangyu commented on a diff in pull request #9678: add tablet erros when close_wait return error
Posted by GitBox <gi...@apache.org>.
pengxiangyu commented on code in PR #9678:
URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876872380
##########
be/src/olap/delta_writer.h:
##########
@@ -70,6 +70,7 @@ class DeltaWriter {
Status close_wait(google::protobuf::RepeatedPtrField<PTabletInfo>* tablet_vec,
google::protobuf::RepeatedPtrField<PTabletError>* tablet_errors,
bool is_broken);
+ Status close_wait();
Review Comment:
it is not ready,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] pengxiangyu closed pull request #9678: add tablet erros when close_wait return error
Posted by GitBox <gi...@apache.org>.
pengxiangyu closed pull request #9678: add tablet erros when close_wait return error
URL: https://github.com/apache/incubator-doris/pull/9678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9678: add tablet erros when close_wait return error
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #9678:
URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876758703
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -137,6 +137,23 @@ Status TabletsChannel::close(int sender_id, int64_t backend_id, bool* finished,
return Status::OK();
}
+void TabletsChannel::_close_wait(DeltaWriter* writer,
Review Comment:
where has this method has been used ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9678: add tablet erros when close_wait return error
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #9678:
URL: https://github.com/apache/incubator-doris/pull/9678#discussion_r876753281
##########
be/src/olap/delta_writer.h:
##########
@@ -70,6 +70,7 @@ class DeltaWriter {
Status close_wait(google::protobuf::RepeatedPtrField<PTabletInfo>* tablet_vec,
google::protobuf::RepeatedPtrField<PTabletError>* tablet_errors,
bool is_broken);
+ Status close_wait();
Review Comment:
why add this method？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org