[jira] [Updated] (LUCENE-6483) Core closed listeners should be called with the same cache key as the one returned by getCoreCacheKey

["Adrien Grand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-6483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand updated LUCENE-6483:
---------------------------------
    Attachment: LUCENE-6483.patch

Here is a patch: it changes FilterLeafReader to wrap the CoreClosedListener if necessary in order to call them on the right core cache key.

> Core closed listeners should be called with the same cache key as the one returned by getCoreCacheKey
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6483
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>         Attachments: LUCENE-6483.patch
>
>
> Core cache keys are typically used for caching, for instance we use them in the query cache and when uninverting.
> However, since FilterLeafReader delegates addCoreClosedListener by default, these listeners will always be called with the cache key of the wrapper reader. So if you happen to use a filter reader that overrides the core cache key, you are going to try to evict on a different key than the one that you used for caching.
> We should ensure that core closed listeners are always called on the same key as the one returned by #getCoreCacheKey



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org