You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Francis ANDRE (Created) (JIRA)" <ji...@apache.org> on 2012/04/08 10:58:21 UTC
[jira] [Created] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
unify admin port and key setting: single point of definition in start.properties
--------------------------------------------------------------------------------
Key: OFBIZ-4793
URL: https://issues.apache.org/jira/browse/OFBIZ-4793
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Environment: WXP SP3 Sun SDK 1.6.0_30
Reporter: Francis ANDRE
Priority: Minor
Attachments: ofbiz-admin-port.patch
Hi
If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
framework/start/src/org/ofbiz/base/start/jetty.properties
Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-4793:
--------------------------------------
Assignee: Jacques Le Roux
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Francis ANDRE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251731#comment-13251731 ]
Francis ANDRE commented on OFBIZ-4793:
--------------------------------------
Jacques
This is already the case:
Start.java@177 calls Config.getInstance(args); which calls Config.getConfigFileName(firstArg); which reads the start.properties as return "org/ofbiz/base/start/" + command + ".properties";
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Francis ANDRE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252534#comment-13252534 ]
Francis ANDRE commented on OFBIZ-4793:
--------------------------------------
Jacques
IMHO, it is likely to leads to some obscur troubles to add those lines
String adminPortStr = getProp(props, "ofbiz.admin.port", "0");
adminKey = getProp(props, "ofbiz.admin.key", "NA");
String adminPortStr = getProp(props, "ofbiz.admin.port", "10523");
adminKey = getProp(props, "ofbiz.admin.key", "so3du5kasd5dn");
because it put the value of the admin port and key in the code instead in letting it only as a configuration property. If oneday someone comments out the admin port/key in the start.properties, he won't understand where are coming those values since there are in the code.
Francis
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Francis ANDRE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis ANDRE updated OFBIZ-4793:
---------------------------------
Attachment: ofbiz-admin-port.patch
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4793.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Francis,
Your patch is in at revision: 1324989
In start.java, I also added the default values I suggested.
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4793) unify admin port and key
setting: single point of definition in start.properties
Posted by "Jacques Le Roux (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251902#comment-13251902 ]
Jacques Le Roux edited comment on OFBIZ-4793 at 4/11/12 8:35 PM:
-----------------------------------------------------------------
Thanks Francis,
Your patch is in at revision: 1324989
In config.java, I also added the default values I suggested.
was (Author: jacques.le.roux):
Thanks Francis,
Your patch is in at revision: 1324989
In start.java, I also added the default values I suggested.
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251905#comment-13251905 ]
Jacques Le Roux commented on OFBIZ-4793:
----------------------------------------
Missed config.java in r1324989, added at r1324990
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252555#comment-13252555 ]
Jacques Le Roux commented on OFBIZ-4793:
----------------------------------------
Hi Francis,
You are right, I don't expect much confusion (since we can still search) but good point, I will remove that
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251494#comment-13251494 ]
Jacques Le Roux commented on OFBIZ-4793:
----------------------------------------
Hi Francis,
It looks good to me
All,
Should we not also change the default values in start.java, using those that are in the properties file?
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4793) unify admin port and key setting:
single point of definition in start.properties
Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251826#comment-13251826 ]
Jacques Le Roux commented on OFBIZ-4793:
----------------------------------------
Francis,
Yes I know, but I mean instead of
String adminPortStr = getProp(props, "ofbiz.admin.port", "0");
adminKey = getProp(props, "ofbiz.admin.key", "NA");
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4793) unify admin port and key
setting: single point of definition in start.properties
Posted by "Jacques Le Roux (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251826#comment-13251826 ]
Jacques Le Roux edited comment on OFBIZ-4793 at 4/11/12 6:39 PM:
-----------------------------------------------------------------
Francis,
Yes I know, but I mean instead of
String adminPortStr = getProp(props, "ofbiz.admin.port", "0");
adminKey = getProp(props, "ofbiz.admin.key", "NA");
String adminPortStr = getProp(props, "ofbiz.admin.port", "10523");
adminKey = getProp(props, "ofbiz.admin.key", "so3du5kasd5dn");
was (Author: jacques.le.roux):
Francis,
Yes I know, but I mean instead of
String adminPortStr = getProp(props, "ofbiz.admin.port", "0");
adminKey = getProp(props, "ofbiz.admin.key", "NA");
> unify admin port and key setting: single point of definition in start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to change currently many files (-- build.xml, various .bat and .sh --). In order to avoid this error-prone pratice, I suggest to centralize the definition of the admin kay and port at 2 single points: the framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira