You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2024/02/20 00:55:53 UTC

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21040


Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................

IMPALA-12821: Fix test_create_table_profile_events depend on event-processor

When event-processor goes into the error state, event related labels
like 'Fetched event batch from Metastore' won't be added into the DDL
profiles, which makes test_create_table_profile_events fail.

This patch removes the event related labels in the test. Also dumps the
actual profiles when the test fails.

Tests:
 - Run the test when event-processor is disabled.

Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
---
M tests/query_test/test_observability.py
1 file changed, 1 insertion(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/21040/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10340/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 07:58:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21040

to look at the new patch set (#2).

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................

IMPALA-12821: Fix test_create_table_profile_events depend on event-processor

When event-processor goes into the error state, event related labels
like 'Fetched event batch from Metastore' won't be added into the DDL
profiles, which makes test_create_table_profile_events fail.

This patch removes the event related labels in the test. Also dumps the
actual profiles when the test fails.

Tests:
 - Run the test when event-processor is disabled.

Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
---
M tests/query_test/test_observability.py
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/21040/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15253/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 01:21:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15254/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 01:22:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 3:

> Patch Set 3: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10338/

The failure is a known issue: IMPALA-12266


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 07:30:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 12:45:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Riza Suminto, Zihao Ye, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21040

to look at the new patch set (#3).

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................

IMPALA-12821: Fix test_create_table_profile_events depend on event-processor

When event-processor goes into the error state, event related labels
like 'Fetched event batch from Metastore' won't be added into the DDL
profiles, which makes test_create_table_profile_events fail.

This patch removes the event related labels in the test. So it's
expected to pass with or without event processor enabled. Also dumps the
actual profiles when the test fails.

Tests:
 - Run the test when event-processor is disabled.

Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
---
M tests/query_test/test_observability.py
1 file changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/21040/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 3: Code-Review+2

Carry +2 from Riza


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 02:05:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21040/2/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/21040/2/tests/query_test/test_observability.py@477
PS2, Line 477: test_create_table_profile_events
nit: I think it is good to mention in comment that this test is expected to pass with or without event processor enabled.
Feel free to add this or not, and please carry my +2.



-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 16:11:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10338/


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 06:59:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................

IMPALA-12821: Fix test_create_table_profile_events depend on event-processor

When event-processor goes into the error state, event related labels
like 'Fetched event batch from Metastore' won't be added into the DDL
profiles, which makes test_create_table_profile_events fail.

This patch removes the event related labels in the test. So it's
expected to pass with or without event processor enabled. Also dumps the
actual profiles when the test fails.

Tests:
 - Run the test when event-processor is disabled.

Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Reviewed-on: http://gerrit.cloudera.org:8080/21040
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_observability.py
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 12:38:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10338/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 02:06:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15372/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 02:30:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12821: Fix test create table profile events depend on event-processor

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )

Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f
Gerrit-Change-Number: 21040
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 07:58:52 +0000
Gerrit-HasComments: No