[GitHub] [airflow] pankajastro commented on a diff in pull request #29502: Validate Hive Beeline parameters

["pankajastro (via GitHub)" <gi...@apache.org>]

pankajastro commented on code in PR #29502:
URL: https://github.com/apache/airflow/pull/29502#discussion_r1105861501


##########
airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -141,6 +141,7 @@ def _prepare_cli_cmd(self) -> list[Any]:
 
         if self.use_beeline:
             hive_bin = "beeline"
+            self._validate_beeline_parameters(conn)

Review Comment:
   hmm, didn't notice maybe makes sense here since we have conn in `__init__`. 
   Not related to changes in this PR but should we think of moving `self.get_connection(hive_cli_conn_id)` call outside `__init__` otherwise it will make a db call to get conn whenever dag parsing will happen?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org