You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/06/27 11:14:30 UTC
Review Request 60462: LENS-1448 : Having clause expressions are not
resolved correctly for JoinCandidates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60462/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1448
https://issues.apache.org/jira/browse/LENS-1448
Repository: lens
Description
-------
In the below query expr1 and expr2 are answered from Cadidate1 and Candidate2 respectively.
The union rewritten query should have both the expressions projected in the inner queries which is not happening right now.
cube select dim1, expr1 from testcube where time_range_in(time, '2017-06-13-00', '2017-06-14-00') having expr2 > ('0')
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 2403576
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java f6c9ce1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f87158c
Diff: https://reviews.apache.org/r/60462/diff/1/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 60462: LENS-1448 : Having clause expressions are
not resolved correctly for JoinCandidates
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60462/#review179076
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 27, 2017, 4:44 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60462/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 4:44 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1448
> https://issues.apache.org/jira/browse/LENS-1448
>
>
> Repository: lens
>
>
> Description
> -------
>
> In the below query expr1 and expr2 are answered from Cadidate1 and Candidate2 respectively.
> The union rewritten query should have both the expressions projected in the inner queries which is not happening right now.
> cube select dim1, expr1 from testcube where time_range_in(time, '2017-06-13-00', '2017-06-14-00') having expr2 > ('0')
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 2403576
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java f6c9ce1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f87158c
>
>
> Diff: https://reviews.apache.org/r/60462/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sushil Mohanty
>
>