You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/14 01:08:05 UTC
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9005: [Refactor](ReportHanlder) Remove some unused schema_hash code
yiguolei commented on code in PR #9005:
URL: https://github.com/apache/incubator-doris/pull/9005#discussion_r850006067
##########
fe/fe-core/src/main/java/org/apache/doris/master/ReportHandler.java:
##########
@@ -296,32 +288,27 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
deleteFromMeta(tabletDeleteFromMeta, backendId, backendReportVersion);
}
- // 4. handle (be - meta)
- if (foundTabletsWithValidSchema.size() != backendTablets.size()) {
- deleteFromBackend(backendTablets, foundTabletsWithValidSchema, foundTabletsWithInvalidSchema, backendId);
Review Comment:
Why delete this code? If it is removed, how to deal with the rubbish tablet on BE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org